Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: museum should always check the upload chart version #320

Closed
scbizu opened this issue Apr 2, 2020 · 1 comment
Closed

proposal: museum should always check the upload chart version #320

scbizu opened this issue Apr 2, 2020 · 1 comment

Comments

@scbizu
Copy link
Contributor

scbizu commented Apr 2, 2020

Hi, there !

Background

  1. Helm only support the valid semver 2 version chart .
  2. But chartmuseum allows the non-semantic chart , and the chart cannot be downloaded from remote museum , it will be the museum garbage until we found it and delete it manually .

Proposal

It is better if we can do some semantic version checking when users upload their chat .

Well , as for details , we should add validate code before we PutObject into the backend storage:

	version,err:=cm_repo.ChartVersionFromStorageObject(storage.Object{
		Content: content,
	})

	sem,err:= semver.Parse(version.Metadata.Version)
	if err!=nil {
		// handle error msg
	}

	if !sem.Validate(){
		// return invalid chart version
	}

Leave me the message if you need the PR .

@jdolitsky
Copy link
Contributor

Hello, if you can add this via PR as configurable option that would be great. Maybe --enforce-semver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants