Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/kong] Ability to add custom annotations to jobs #19563

Closed
daBeuh opened this issue Dec 12, 2019 · 3 comments
Closed

[stable/kong] Ability to add custom annotations to jobs #19563

daBeuh opened this issue Dec 12, 2019 · 3 comments

Comments

@daBeuh
Copy link

daBeuh commented Dec 12, 2019

Is your feature request related to a problem? Please describe.
When using Istio with an opt-out sidecar injection policy, migration jobs will fail to complete, thus preventing the rest of the installation / upgrade.
Like explained in this article, Istio works by injecting a Sidecar container & a Job is not considered complete until all containers have stopped running, but Istio Sidecars run indefinitely.

This can be disabled by using the annotation sidecar.istio.io/inject: false but the chart does not seem to allow custom annotations for the jobs.

Describe the solution you'd like
The ability to add custom annotations to the jobs in the helm chart.

Describe alternatives you've considered
Disabling the jobs completely with runMigrations: false or changing Istio injection policy to an opt-in one.

Additional context
I looked at jobs from other charts & I didn't find any Job allowing custom annotation. Am I completely missing something? Is it a really bad idea?

@hbagdi
Copy link
Collaborator

hbagdi commented Jan 7, 2020

PR welcome to add custom annotations on Jobs via values.

@hbagdi
Copy link
Collaborator

hbagdi commented Jan 21, 2020

Please open this issue in Kong charts repo at https://github.com/kong/charts and close this one. Thank you.

@hbagdi
Copy link
Collaborator

hbagdi commented Jan 23, 2020

I opened up Kong/charts#19 to track this.
Please close this issue.
Thanks!

@daBeuh daBeuh closed this as completed Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants