You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
Is your feature request related to a problem? Please describe.
When using Istio with an opt-out sidecar injection policy, migration jobs will fail to complete, thus preventing the rest of the installation / upgrade.
Like explained in this article, Istio works by injecting a Sidecar container & a Job is not considered complete until all containers have stopped running, but Istio Sidecars run indefinitely.
This can be disabled by using the annotation sidecar.istio.io/inject: false but the chart does not seem to allow custom annotations for the jobs.
Describe the solution you'd like
The ability to add custom annotations to the jobs in the helm chart.
Describe alternatives you've considered
Disabling the jobs completely with runMigrations: false or changing Istio injection policy to an opt-in one.
Additional context
I looked at jobs from other charts & I didn't find any Job allowing custom annotation. Am I completely missing something? Is it a really bad idea?
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
When using Istio with an opt-out sidecar injection policy, migration jobs will fail to complete, thus preventing the rest of the installation / upgrade.
Like explained in this article, Istio works by injecting a Sidecar container & a Job is not considered complete until all containers have stopped running, but Istio Sidecars run indefinitely.
This can be disabled by using the annotation
sidecar.istio.io/inject: false
but the chart does not seem to allow custom annotations for the jobs.Describe the solution you'd like
The ability to add custom annotations to the jobs in the helm chart.
Describe alternatives you've considered
Disabling the jobs completely with
runMigrations: false
or changing Istio injection policy to an opt-in one.Additional context
I looked at jobs from other charts & I didn't find any Job allowing custom annotation. Am I completely missing something? Is it a really bad idea?
The text was updated successfully, but these errors were encountered: