-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
selector not generated for Deployment when upgrade extensions/v1beta1 to apps/v1 #34
Comments
@isaactl If you update the chart to contain the |
hi @hickeyma yes, in that case, i can do the upgrade without an issue. |
@isaactl It is good that you are able to progress and not blocked.
It is a good point that you raise. I would however prefer keeping the plugin to do the sole job of updating release APIs. I want to avoid introducing additional capabilities as there are numerous other updates that could be added like status etc. The problem with this is that the code base would balloon and a limit would be found on what could be supported or not. The plugin should be simple. Hope this answers your questions. |
@hickeyma i understand keep this plugin simple is important, so i'll close this issue. thanks for the reply! |
background
we have a old version(extensions/v1beta1) of configuration for Deployment that didn't set selector field, this has been running in k8s 1.14. While migrating to k8s 1.16, we found extensions/v1beta1 has deprecated. for the new version 'apps/v1', the selector field is now a required field according to schema. than i use this plugin to upgrade configuration in cluster
issue
although we have the apiVersion upgraded, but the selector field is not generated, and cause some issues to do further helm upgrade
Any thoughts, ideas will be appreciated!
The text was updated successfully, but these errors were encountered: