Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HELM_PLUGIN_SELF -> HELM_PLUGIN_DIR #10380

Merged
merged 2 commits into from Nov 26, 2021

Conversation

tylerauerbeck
Copy link
Contributor

What this PR does / why we need it:
This PR updates references of HELM_PLUGIN_SELF to HELM_PLUGIN_DIR

resolves #10354

Special notes for your reviewer:

If applicable:

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
@helm-bot helm-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2021
@mattfarina mattfarina added this to the 3.8.0 milestone Nov 22, 2021
@hickeyma
Copy link
Contributor

@tylerauerbeck Can you push commit again to restart CI as some issue with it being blocked?

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
@tylerauerbeck
Copy link
Contributor Author

@hickeyma Pushed another. Let me know if this helps.

Copy link
Member

@yxxhero yxxhero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bacongobbler bacongobbler merged commit 4bf99e5 into helm:main Nov 26, 2021
zak905 pushed a commit to zak905/helm that referenced this pull request Jan 19, 2023
* Update HELM_PLUGIN_SELF -> HELM_PLUGIN_DIR

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>

* Trigger Build

Signed-off-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>

Co-authored-by: Tyler Auerbeck <tylerauerbeck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Old References to HELM_PLUGIN_SELF
6 participants