Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to skip CRD only from a dependency #10540

Closed
sathieu opened this issue Jan 11, 2022 · 5 comments
Closed

Allow to skip CRD only from a dependency #10540

sathieu opened this issue Jan 11, 2022 · 5 comments

Comments

@sathieu
Copy link
Contributor

sathieu commented Jan 11, 2022

Allow to skip CRDs at dependency level:

# Chart.yaml
apiVersion: v2
name: "istio"
version: 0.0.1
dependencies:
  - name: kube-prometheus-stack
    repository: https://gitlab.example.org/api/v4/projects/external-packages%2Fprometheus-stack/packages/helm/stable/
    version: 30.0.1
    skipCRDs: true

Output of helm version:

version.BuildInfo{Version:"v3.7.2", GitCommit:"663a896f4a815053445eec4153677ddc24a0a361", GitTreeState:"clean", GoVersion:"go1.16.10"}

Output of kubectl version:

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.5", GitCommit:"aea7bbadd2fc0cd689de94a54e5b7b758869d691", GitTreeState:"clean", BuildDate:"2021-09-15T21:10:45Z", GoVersion:"go1.16.8", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.5", GitCommit:"5c99e2ac2ff9a3c549d9ca665e7bc05a3e18f07e", GitTreeState:"clean", BuildDate:"2021-12-16T08:32:32Z", GoVersion:"go1.16.12", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):

Bare-metal (kubespray)

@mattfarina
Copy link
Collaborator

Could you please share your use case for this?

helm install already has a --skip-crds flag so that the one doing the install can skip all of the CRDs at install time. What would this do differently and for whom?

@sathieu
Copy link
Contributor Author

sathieu commented Jan 11, 2022

@mattfarina My usecase (I'm using ArgoCD as gitops tool):

  • I install a chart depending on the kube-prometheus-stack in one namespace
  • I install another chart depending on kube-prometheus-stack and istio in another namespace

I get two prometheus installs (a main one, and another dedicated to istio, with shorter scraping interval and shorter retention), but I only want to install the CRDs once. In the second chart, I want the istio CRDs but not the prometheus CRDs.

As a workaround, I can use 3 charts, but I prefer to group istio and it's prometheus, because those are tightly linked.

@Cheshirez
Copy link

Upvote for this feature as it allow to control sources for CRDs without interference from dependencies or subdependencies.

@github-actions
Copy link

This issue has been marked as stale because it has been open for 90 days with no activity. This thread will be automatically closed in 30 days if no further activity occurs.

@cuongquach
Copy link

I think this feature is useful for us in management group of helm dependency resources with CRDs. Could we re-open this issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants