New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Helm plugin install and update from VCS #10971
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mihael Rodek <mihael.rodek1@gmail.com>
…instal-version-handling Updated plugin update and install to handle plugin versioning
Forgot to correct tests, on to it |
@bacongobbler @hickeyma @mattfarina Sorry for pinging you but since I'm still waiting on any comment for issue #10929, I'd like to address and comment this PR with any of you or anyone else contributing to Helm project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request. I have not done a full review. I just took a quick look and from that I had some feedback. Hope this helps you refine it.
Signed-off-by: Mihael Rodek <mihael.rodek1@gmail.com>
@mattfarina did you take a second look on this PR? could I get any feedback please? |
@mihaelrodek thank you for fixing this issue, I just encountered it when I tried to update |
Thanks @arogulin, this PR has been opened for year now but no actions have been taken so far, could maybe some of you take a look at it? @mattfarina @marckhouzam @joejulian @jdolitsky @sabre1041 @scottrigby @technosophos @hickeyma |
Signed-off-by: Mihael Rodek mihael.rodek1@gmail.com
closes #10929
What this PR does / why we need it: Fixes the plugin update and plugin install commands using better version handling
please refer to issue #10929 for more detailed explanation
Special notes for your reviewer: Plugin now prioritizes latest version over the cached one
e.g.
helm plugin install [options] <path|url>...
now installs the latest version and not one fetched from cachehelm plugin update <plugin:[version]>...
now allows user to specify to which version should plugin be updated to