Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind Sorter missing list based resources #12896

Open
jmajoor opened this issue Mar 19, 2024 · 2 comments
Open

Kind Sorter missing list based resources #12896

jmajoor opened this issue Mar 19, 2024 · 2 comments

Comments

@jmajoor
Copy link

jmajoor commented Mar 19, 2024

The kind sorter is missing many of the list based resources.
For example:
Deployment, StatefulSet, ReplicaSet, DaemonSet, Ingress, Service, ConfigMap are defined in the kind sorter, but DeploymentList, StatefulSetList, ReplicaSetList, DaemonSetList, IngressList, ServiceList, ConfigMapList are missing.

There are a few list based resources such as RoleList and SecretList.

Would it be possible for the install/uninstall order to systematically add the corresponding list resource?
Or otherwise make sure that resources are always added in pairs.

@z4ce
Copy link
Contributor

z4ce commented Mar 19, 2024

Do you have an example of current behavior and desired behavior?

@jmajoor
Copy link
Author

jmajoor commented Mar 19, 2024

The current behavior can result in failures due to dependencies across resources, due to missing dependent resources.

For example if you define a ConfigMapList and have a Deployment that refers to config maps created in that list, then the deployment will fail because the ConfigMapList will be created after the deployment instead of before.

Or with a ServiceList and then having an Ingress definition refering to the service. The ServiceList needs to be created before the Ingress.

In other words the current behavior is that all resources not listed in the kind sorter will be created in no particular order at the end, and this can cause failures with dependencies.

Desired behavior is for all List variants of resources to be defined at the same level in the kind sorter as their non-list equivalent, to avoid deployment failures due to cross dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants