Make retryingRoundTripper type public

[Valgueiro]

Hello team,

My team encountered an issue in Fluxcd (fluxcd/flux2#4804) that seems to be related to an issue that was already solved here (#11426). When trying to replicate the solution there, I saw on the code that the retryingRoundTripper is private to the helm cli package (https://github.com/helm/helm/blob/main/pkg/cli/roundtripper.go#L27).

Can we make it public? Do you guys see any issues on doing this?

[jnummelin]

plus one on this one

We also use Helm as library in our project and having to "inline" the retryingRoundTripper would be unwanted.

[gjenkins8]

Thinking out aloud -- would it make more sense to expose a public helper in https://github.com/kubernetes/cli-runtime ?

Agree, that if this code might provide utility across multiple projects, then it could be made public. But I think that the Helm repo is probably not the best place to expose generic Kubernetes code from. Thoughts?

[jnummelin]

In our case we use helm functionality as a library. That means we have to construct the actions client separately and thus we cannot easily use the roundtripper as it's private. We did find a workaround to get it but it's not really pretty. I'd rather have used it directly. https://github.com/k0sproject/k0s/pull/4515/files