Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm completion does not auto-complete releases or charts #3170

Closed
thomas-riccardi opened this issue Nov 20, 2017 · 12 comments
Closed

helm completion does not auto-complete releases or charts #3170

thomas-riccardi opened this issue Nov 20, 2017 · 12 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. question/support

Comments

@thomas-riccardi
Copy link

thomas-riccardi commented Nov 20, 2017

helm completion does not auto-complete releases or charts:

# Releases
$ helm ls
NAME            REVISION        UPDATED                         STATUS          CHART           NAMESPACE
smelly-newt     3               Mon Nov 20 11:41:29 2017        DEPLOYED        rabbitmq-0.6.10 dev 
$ helm history <TAB>
# suggests local files instead of existing releases

# Charts
$ helm charts <TAB>
# suggests local files only, could also suggest charts from repositories

As an example, kubectl has auto-completion on remote resources, and it's really much more useful than what helm has.

@bacongobbler bacongobbler added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. question/support labels Nov 21, 2017
@particledecay
Copy link

For what it's worth, I also anticipated the completion to be more like kubectl and autocomplete a release name/chart name. The local file thing was unexpected.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@thomas-riccardi
Copy link
Author

/remove-lifecycle stale

The feature is still missing as far as I know.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@thomas-riccardi
Copy link
Author

/remove-lifecycle stale
/lifecycle frozen

@Vickey-Wu
Copy link

helm completion bash
source <(helm completion bash)

helm docs

@thomas-riccardi
Copy link
Author

@Vickey-Wu yes there is a minimal bash auto-completion support in helm, but it does not dynamically auto-completes releases names and such like kubectl does.
I checked the new helm 2.10 version, as well as the changelog, commits and code: there is nothing new: the feature is still missing.

@bacongobbler
Copy link
Member

bacongobbler commented Aug 22, 2018

Feel like working on a fix? :)

Bash autocompletion is a feature of spf13/cobra which we turned on but I don't think anyone from the core maintainers use it, so someone from the community more familiar with bash autocompletion would be more suited to the task than we would, quite honestly.

@cory-klein
Copy link

I've looked into how this is done in kubectl and it goes beyond my level of area expertise. I am 🤞 that somebody that has the matching cross section of skills between shell completion and the tools behind the helm/kubectl CLIs comes across this issue.

@marckhouzam
Copy link
Member

marckhouzam commented Jul 30, 2019

The completion of releases has been done in #5562 for v2 (part of helm 2.15.0) and by #5829 for v3.

Still more dynamic completions can be added, such as charts, as suggested in this issue.

@marckhouzam
Copy link
Member

The completion of charts has been implemented in #6730 for Helm 3.

The two dynamic completions requested in this issue will be part of helm 3 so I feel this issue can be closed.
cc @bacongobbler

@bacongobbler
Copy link
Member

thanks @marckhouzam for the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. question/support
Projects
None yet
Development

No branches or pull requests

8 participants