Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm completion does not support commands aliases #3171

Closed
thomas-riccardi opened this issue Nov 20, 2017 · 8 comments · Fixed by spf13/cobra#669
Closed

helm completion does not support commands aliases #3171

thomas-riccardi opened this issue Nov 20, 2017 · 8 comments · Fixed by spf13/cobra#669
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. question/support

Comments

@thomas-riccardi
Copy link

# OK
$ helm list --<TAB>
--all                --date               --debug              --deleted            --deleting           --deployed           --failed             --home=              --host=              --kube-context=      --max=
--namespace=         --offset=            --pending            --reverse            --short              --tiller-namespace=  --tls                --tls-ca-cert=       --tls-cert=          --tls-key=           --tls-verify

# KO
$ helm ls --<TAB>
--debug              --home=              --host=              --kube-context=      --tiller-namespace=
@bacongobbler bacongobbler added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. question/support labels Nov 21, 2017
@rajatjindal
Copy link
Contributor

rajatjindal commented Dec 9, 2017

Aliases Fixed

$ helm ls --
--all --deleted --failed --kube-context= --namespace= --reverse --tls --tls-key=
--date --deleting --home= --kubeconfig= --offset= --short --tls-ca-cert= --tls-verify
--debug --deployed --host= --max= --pending --tiller-namespace= --tls-cert=

original continues to work

$ helm list --
--all --deleted --failed --kube-context= --namespace= --reverse --tls --tls-key=
--date --deleting --home= --kubeconfig= --offset= --short --tls-ca-cert= --tls-verify
--debug --deployed --host= --max= --pending --tiller-namespace= --tls-cert=

This is fixed by spf13/cobra#588

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@thomas-riccardi
Copy link
Author

/remove-lifecycle rotten

@thomas-riccardi
Copy link
Author

fix in cobra was merged (spf13/cobra#588) but cobra dependency in helm was not updated.

@thomas-riccardi
Copy link
Author

I still reproduce the issue with helm 2.9.0.

@bacongobbler
Copy link
Member

We still need to bump cobra to bring in this fix. Re-opening!

@marckhouzam
Copy link
Member

This can be closed.
Cobra has been updated a couple of time since this was a problem.
I believe this was fixed when #4913 was merged.
It is part of Helm 2.12 if I'm not mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. question/support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants