Spelling #7258

jsoref · 2019-12-17T19:10:44Z

Generated by https://github.com/jsoref/spelling f; to maintain your repo, please consider fchurn

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

pkg/cli/values/options.go

pkg/storage/driver/driver.go

cmd/helm/flags.go

jsoref · 2019-12-17T19:12:14Z

cmd/helm/root_test.go

@@ -31,7 +31,7 @@ func TestRootCmd(t *testing.T) {

 	tests := []struct {
 		name, args, cachePath, configPath, dataPath string
-		envars                                      map[string]string
+		envvars                                     map[string]string


envvars is more common

jsoref · 2019-12-17T19:12:41Z

pkg/chartutil/chartfile.go

@@ -43,7 +43,7 @@ func LoadChartfile(filename string) (*chart.Metadata, error) {
 // 'filename' should be the complete path and filename ('foo/Chart.yaml')
 func SaveChartfile(filename string, cf *chart.Metadata) error {
 	// Pull out the dependencies of a v1 Chart, since there's no way
-	// to tell the serialiser to skip a field for just this use case
+	// to tell the serializer to skip a field for just this use case


This is more common in this repository.

jsoref · 2019-12-17T19:13:45Z

pkg/chartutil/doc.go

@@ -17,15 +17,15 @@ limitations under the License.
 /*Package chartutil contains tools for working with charts.

 Charts are described in the protocol buffer definition (pkg/proto/charts).
-This packe provides utilities for serializing and deserializing charts.
+This package provides utilities for serializing and deserializing charts.


I'm guessing based on line 17

jsoref · 2019-12-17T19:14:16Z

pkg/chartutil/errors_test.go

@@ -20,15 +20,15 @@ import (
 	"testing"
 )

-func TestErrorNoTableDoesntPanic(t *testing.T) {
+func TestErrorNoTableDoesNotPanic(t *testing.T) {


I'm willing to drop any commit if people object.

jsoref · 2019-12-17T19:16:03Z

pkg/plugin/installer/http_installer_test.go

@@ -234,12 +234,12 @@ func TestExtract(t *testing.T) {
 	gz.Close()
 	// END tarball creation

-	extr, err := NewExtractor(source)
+	extractor, err := NewExtractor(source)


The tested code uses this spelling...

jsoref · 2019-12-17T19:16:23Z

pkg/repo/doc.go

@@ -27,7 +27,7 @@ The first is the 'index.yaml' format, which is expressed like this:
 	entries:
 	  frobnitz:
 	  - created: 2016-09-29T12:14:34.830161306-06:00
-		description: This is a frobniz.
+		description: This is a frobnitz.


This is the actual name of the module...

jsoref · 2019-12-17T19:17:52Z

pkg/repo/index_test.go

@@ -131,7 +131,7 @@ func TestMerge(t *testing.T) {

 	if len(ind1.Entries) != 2 {
 		t.Errorf("Expected 2 entries, got %d", len(ind1.Entries))
-		vs := ind1.Entries["dreadnaught"]
+		vs := ind1.Entries["dreadnought"]


afaict, this code is unreachable/untested/would not work.

See lines 116/122.

I could be wrong, but as w/ jabbathehut, if there's a specific reason for misspelling something, it should be clearly identified.

pkg/storage/driver/driver.go

jsoref · 2019-12-17T19:49:27Z

@bacongobbler: I think I've dropped the objectionable commits.

jsoref · 2019-12-17T19:50:15Z

(sorry, mouse missed... -- not a fan of how easy MSGitHub makes it for one to accidentally do that)

hickeyma

LGTM, thanks @jsoref

* spelling: constraint Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: cryptographic Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: dependency Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: doesnot Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: don't Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unexpected Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: dreadnought Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: default Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: envvars Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: evaluates Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: execute Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: extractor Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: frobnitz Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: generated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: implementation Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: jabba Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: keywords Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: kubernetes Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: override Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: package Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: parsable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: progress Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: recursively Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: release Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: cache Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: representing Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: serializer Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: subchart Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: utilities Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 29 commits December 16, 2019 15:27

spelling: cryptographic

b2f24ef

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: doesnot

34cb82b

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: don't

3656170

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: dreadnought

6d1d622

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: default

1b6a1e6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: dependency

74e98b6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: envvars

710235d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: evaluates

b74f472

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: execute

6886b20

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: extractor

4ed4e88

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: frobnitz

45ee1c2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: generated

4c71039

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: implementation

be02e4c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: jabba

e1b54f7

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: keywords

8f10a8a

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: kubernetes

487dc4d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: override

388f867

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: package

c34b672

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: parsable

8f8b491

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: progress

2a04d68

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: recursively

a4ecdb1

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: release

ef083b2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: cache

56d664d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: constraint

67d7ae9

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: representing

8538418

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: serializer

11d5714

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: subchart

a1d62d0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: unexpected

9bf7c41

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: utilities

5d6fc67

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

helm-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 17, 2019

bacongobbler requested changes Dec 17, 2019

View reviewed changes

jsoref commented Dec 17, 2019

View reviewed changes

jsoref force-pushed the spelling branch 2 times, most recently from 133795a to 5d6fc67 Compare December 17, 2019 19:47

jsoref closed this Dec 17, 2019

jsoref reopened this Dec 17, 2019

bacongobbler approved these changes Dec 17, 2019

View reviewed changes

hickeyma approved these changes Dec 18, 2019

View reviewed changes

hickeyma merged commit 02ad2b1 into helm:master Dec 18, 2019

jsoref deleted the spelling branch December 18, 2019 14:35

jsoref mentioned this pull request Feb 24, 2021

chore: Spelling #9410

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #7258

Spelling #7258

jsoref commented Dec 17, 2019 •

edited

jsoref Dec 17, 2019

jsoref Dec 17, 2019

jsoref Dec 17, 2019

jsoref Dec 17, 2019

jsoref Dec 17, 2019

jsoref Dec 17, 2019

jsoref Dec 17, 2019

jsoref commented Dec 17, 2019

jsoref commented Dec 17, 2019

hickeyma left a comment

Spelling #7258

Spelling #7258

Conversation

jsoref commented Dec 17, 2019 • edited

jsoref Dec 17, 2019

Choose a reason for hiding this comment

jsoref Dec 17, 2019

Choose a reason for hiding this comment

jsoref Dec 17, 2019

Choose a reason for hiding this comment

jsoref Dec 17, 2019

Choose a reason for hiding this comment

jsoref Dec 17, 2019

Choose a reason for hiding this comment

jsoref Dec 17, 2019

Choose a reason for hiding this comment

jsoref Dec 17, 2019

Choose a reason for hiding this comment

jsoref commented Dec 17, 2019

jsoref commented Dec 17, 2019

hickeyma left a comment

Choose a reason for hiding this comment

jsoref commented Dec 17, 2019 •

edited