Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRDs get deleted when moving them from templates/ to crds/ #8163

Closed
John-Athan opened this issue May 19, 2020 · 2 comments
Closed

CRDs get deleted when moving them from templates/ to crds/ #8163

John-Athan opened this issue May 19, 2020 · 2 comments

Comments

@John-Athan
Copy link

Description

Assume a CRD that is first declared as a template. This CRD then gets moved to the crds directory (with all templating removed). Now, when doing a Helm upgrade, all CRDs will get removed. If many custom resources are connected to this CRD, the upgrade will basically shut most of the cluster down. Is this intentional? Is there a way to work around this?

Steps to reproduce

  1. Install a chart that declares CRDs using templating, for example Strimzi Kafka Operator
  2. Move the CRDs to the crds/ folder
  3. Do a helm upgrade

Versions

Output of helm version:
version.BuildInfo{Version:"v3.2.1", GitCommit:"fe51cd1e31e6a202cba7dead9552a6d418ded79a", GitTreeState:"clean", GoVersion:"go1.13.10"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-21T01:25:41Z", GoVersion:"go1.13.10", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:48:36Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Minikube

@bacongobbler
Copy link
Member

If a resource is removed from the templates directory, the resource is removed. This seems in line with the expected behaviour.

@bacongobbler
Copy link
Member

Duplicate of #7279. See the following for more information:

#7279
#7320
#7505
#7571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants