Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Duplicate keys should error #73

Closed
EvanHahn opened this issue Sep 24, 2018 · 3 comments
Closed

Duplicate keys should error #73

EvanHahn opened this issue Sep 24, 2018 · 3 comments
Assignees

Comments

@EvanHahn
Copy link
Member

This should be invalid:

csp({
  directives: {
    'script-src': ['example.com'],
    scriptSrc: ['example.com']
  }
})

This is a breaking change, so we'll need to do it in Helmet 4.

@knoxcard
Copy link
Contributor

I agree, this is easy code to write and I found myself doing this a bunch of times.

@EvanHahn EvanHahn self-assigned this Feb 23, 2020
@EvanHahn
Copy link
Member Author

EvanHahn commented Aug 2, 2020

This has been addressed in helmet@4 and helmet-csp@3.0.0.

@EvanHahn EvanHahn closed this as completed Aug 2, 2020
@EvanHahn
Copy link
Member Author

EvanHahn commented Aug 2, 2020

This has been addressed in helmet@4 and helmet-csp@3.0.0.

I'm going to be archiving this repository soon and moving everything to https://github.com/helmetjs/helmet/, so feel free to open an issue there if you run into any problems.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants