Issue with release dependencies with `needs` and multiple files #1165

ghost · 2023-11-23T11:43:37Z

Operating system

MacOS 13.6.1

Helmfile Version

v0.158.1

Helm Version

v3.13.2

Bug description

helmfile fails to find release dependencies when using multiple files, using attached sample files:

$ helmfile -f helmfile-all.yaml list
NAME     	NAMESPACE	ENABLED	INSTALLED	LABELS	CHART                      	VERSION
release-1	default  	true   	true     	      	ingress-nginx/ingress-nginx	4.8.1
release-2	default  	true   	true     	      	ingress-nginx/ingress-nginx	4.8.1
$ helmfile -f helmfile-all.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile1003781602/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile1003781602/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Linting release=release-2, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile1003781602/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile1003781602/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

But when the release-1 is moved to a separate file:

$ helmfile -f helmfile-split.yaml list
NAME     	NAMESPACE	ENABLED	INSTALLED	LABELS	CHART                      	VERSION
release-1	default  	true   	true     	      	ingress-nginx/ingress-nginx	4.8.1
release-2	default  	true   	true     	      	ingress-nginx/ingress-nginx	4.8.1
$ helmfile -f helmfile-split.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile1196831173/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile1196831173/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Fetching ingress-nginx/ingress-nginx
in ./helmfile-split.yaml: release(s) "default/release-2" depend(s) on an undefined release "default/release-1". Perhaps you made a typo in "needs" or forgot defining a release named "release-1" with appropriate "namespace" and "kubeContext"?

Example helmfile.yaml

helmfile-all.yaml:

repositories:
  - name: ingress-nginx
    url: https://kubernetes.github.io/ingress-nginx

releases:
  - chart: ingress-nginx/ingress-nginx
    version: 4.8.1
    name: release-1
    namespace: default
  - chart: ingress-nginx/ingress-nginx
    version: 4.8.1
    name: release-2
    namespace: default
    needs:
      - release-1

helmfile-split.yaml:

repositories:
  - name: ingress-nginx
    url: https://kubernetes.github.io/ingress-nginx

helmfiles:
  - helmfile-release-1.yaml

releases:
  - chart: ingress-nginx/ingress-nginx
    version: 4.8.1
    name: release-2
    namespace: default
    needs:
      - release-1

helmfile-release-1.yaml:

repositories:
  - name: ingress-nginx
    url: https://kubernetes.github.io/ingress-nginx

releases:
  - chart: ingress-nginx/ingress-nginx
    version: 4.8.1
    name: release-1
    namespace: default

Error message you've seen (if any)

in ./helmfile-split.yaml: release(s) "default/release-2" depend(s) on an undefined release "default/release-1". Perhaps you made a typo in "needs" or forgot defining a release named "release-1" with appropriate "namespace" and "kubeContext"?

Steps to reproduce

Given in the issue description, but basically helmfile -f helmfile-split.yaml lint.

Working Helmfile Version

(none)

Relevant discussion

No response

The text was updated successfully, but these errors were encountered:

ghost · 2023-11-27T12:54:19Z

Still occurring with:

$ helmfile version

▓▓▓ helmfile

  Version            v0.159.0
  Git Commit         "brew"
  Build Date         24 Nov 23 01:42 CET (3 days ago)
  Commit Date        24 Nov 23 01:42 CET (3 days ago)
  Dirty Build        no
  Go version         1.21.4
  Compiler           gc
  Platform           darwin/amd64

$ helmfile -f helmfile-all.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile3746902576/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile3746902576/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Linting release=release-2, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile3746902576/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile3746902576/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

$ helmfile -f helmfile-split.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile1230466951/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile1230466951/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Fetching ingress-nginx/ingress-nginx
in ./helmfile-split.yaml: release(s) "default/release-2" depend(s) on an undefined release "default/release-1". Perhaps you made a typo in "needs" or forgot defining a release named "release-1" with appropriate "namespace" and "kubeContext"?

yxxhero · 2023-11-27T23:51:21Z

@kpawlik-splunk thanks for your issue.

stale · 2023-12-12T01:37:47Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ghost · 2023-12-12T09:04:43Z

/remove wontfix

stale · 2023-12-26T16:07:56Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ghost · 2024-01-03T11:16:17Z

Tested with latest version and this is still the case:

$ helmfile version

▓▓▓ helmfile

  Version            v0.160.0
  Git Commit         "brew"
  Build Date         22 Dec 23 22:36 CET (1 week ago)
  Commit Date        22 Dec 23 22:36 CET (1 week ago)
  Dirty Build        no
  Go version         1.21.5
  Compiler           gc
  Platform           darwin/amd64

$ helmfile -f helmfile-all.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile779621146/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile779621146/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Linting release=release-2, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile779621146/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile779621146/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed
$ helmfile -f helmfile-split.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile3910696982/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile3910696982/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Fetching ingress-nginx/ingress-nginx
in ./helmfile-split.yaml: release(s) "default/release-2" depend(s) on an undefined release "default/release-1". Perhaps you made a typo in "needs" or forgot defining a release named "release-1" with appropriate "namespace" and "kubeContext"?

jer0enA · 2024-01-04T06:27:37Z

I have the same problem, using version v0.160.0. Using helmfiles: to include multiple releases it looks like need is not able to find the other releases.

austince · 2024-01-12T17:22:18Z

Also an issue if using --selector. Even if the selected releases have no needs, the needs in an unselected release still causes it to fail with the:

release(s) "default/release-2" depend(s) on an undefined release "default/release-1". Perhaps you made a typo in "needs" or forgot defining a release named "release-1" with appropriate "namespace" and "kubeContext"?

stale · 2024-01-26T18:45:44Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

ghost · 2024-02-07T10:47:09Z

Tested with latest version:

$ helmfile version

▓▓▓ helmfile

  Version            v0.161.0
  Git Commit         "brew"
  Build Date         24 Jan 24 02:01 CET (2 weeks ago)
  Commit Date        24 Jan 24 02:01 CET (2 weeks ago)
  Dirty Build        no
  Go version         1.21.6
  Compiler           gc
  Platform           darwin/amd64

$ helmfile -f helmfile-all.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile2024464535/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile2024464535/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Linting release=release-2, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile2024464535/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile2024464535/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

$ helmfile -f helmfile-split.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile180109289/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile180109289/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Fetching ingress-nginx/ingress-nginx
in ./helmfile-split.yaml: release(s) "default/release-2" depend(s) on an undefined release "default/release-1". Perhaps you made a typo in "needs" or forgot defining a release named "release-1" with appropriate "namespace" and "kubeContext"?

fafarun · 2024-02-15T18:55:25Z

Someone know how fix this issue ?

ghost · 2024-02-26T09:05:46Z

(preventing wontfix label from being added)

$ helmfile version

▓▓▓ helmfile

  Version            v0.162.0
  Git Commit         "brew"
  Build Date         18 Feb 24 05:10 CET (1 week ago)
  Commit Date        18 Feb 24 05:10 CET (1 week ago)
  Dirty Build        no
  Go version         1.22.0
  Compiler           gc
  Platform           darwin/amd64

$ helmfile -f helmfile-all.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile4086749705/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile4086749705/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Linting release=release-2, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile4086749705/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile4086749705/default/release-2/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

$ helmfile -f helmfile-split.yaml lint
Adding repo ingress-nginx https://kubernetes.github.io/ingress-nginx
"ingress-nginx" has been added to your repositories

Fetching ingress-nginx/ingress-nginx
Linting release=release-1, chart=/var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile555423063/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx
==> Linting /var/folders/rh/z33gzdts36bb722jk1wmwdwr0000gn/T/helmfile555423063/default/release-1/ingress-nginx/ingress-nginx/4.8.1/ingress-nginx

1 chart(s) linted, 0 chart(s) failed

Fetching ingress-nginx/ingress-nginx
in ./helmfile-split.yaml: release(s) "default/release-2" depend(s) on an undefined release "default/release-1". Perhaps you made a typo in "needs" or forgot defining a release named "release-1" with appropriate "namespace" and "kubeContext"?

yxxhero · 2024-02-26T09:35:26Z

@fafarun I am so busy recently. PR is welcome. thanks so much.

yxxhero · 2024-02-26T09:49:38Z

@fafarun I'll try to work on this. but maybe in the future.

stale bot added the wontfix This will not be worked on label Dec 12, 2023

stale bot removed the wontfix This will not be worked on label Dec 12, 2023

stale bot added the wontfix This will not be worked on label Dec 26, 2023

yxxhero removed the wontfix This will not be worked on label Dec 27, 2023

stale bot added the wontfix This will not be worked on label Jan 26, 2024

stale bot closed this as completed Feb 3, 2024

yxxhero reopened this Feb 3, 2024

stale bot removed the wontfix This will not be worked on label Feb 3, 2024

yxxhero added feature in progress labels Feb 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Issue with release dependencies with `needs` and multiple files #1165

Issue with release dependencies with `needs` and multiple files #1165

ghost commented Nov 23, 2023

ghost commented Nov 27, 2023

yxxhero commented Nov 27, 2023

stale bot commented Dec 12, 2023

ghost commented Dec 12, 2023

stale bot commented Dec 26, 2023

ghost commented Jan 3, 2024

jer0enA commented Jan 4, 2024 •

edited

austince commented Jan 12, 2024

stale bot commented Jan 26, 2024

ghost commented Feb 7, 2024

fafarun commented Feb 15, 2024

ghost commented Feb 26, 2024

yxxhero commented Feb 26, 2024

yxxhero commented Feb 26, 2024

Issue with release dependencies with needs and multiple files #1165

Issue with release dependencies with needs and multiple files #1165

Comments

ghost commented Nov 23, 2023

Operating system

Helmfile Version

Helm Version

Bug description

Example helmfile.yaml

Error message you've seen (if any)

Steps to reproduce

Working Helmfile Version

Relevant discussion

ghost commented Nov 27, 2023

yxxhero commented Nov 27, 2023

stale bot commented Dec 12, 2023

ghost commented Dec 12, 2023

stale bot commented Dec 26, 2023

ghost commented Jan 3, 2024

jer0enA commented Jan 4, 2024 • edited

austince commented Jan 12, 2024

stale bot commented Jan 26, 2024

ghost commented Feb 7, 2024

fafarun commented Feb 15, 2024

ghost commented Feb 26, 2024

yxxhero commented Feb 26, 2024

yxxhero commented Feb 26, 2024

Issue with release dependencies with `needs` and multiple files #1165

Issue with release dependencies with `needs` and multiple files #1165

jer0enA commented Jan 4, 2024 •

edited