Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helmwave build requires working stand #537

Closed
Blobson opened this issue Jan 16, 2023 · 3 comments
Closed

helmwave build requires working stand #537

Blobson opened this issue Jan 16, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Blobson
Copy link

Blobson commented Jan 16, 2023

Describe the bug
For now there is no way you can run helmwave build with invalid KUBE_CONFIG or if somebody is running helwave up in parallel or if you try to test charts with incompatible changes.

With invalid KUBE_CONFIG, you will get an error:

[🤬 aka FATAL]: I can't check if release is installed
        release: tp-docs-ui-demo-tp@demo-tp-infra
        error: Kubernetes cluster unreachable: Get "https://172.28.15.241:64434/version": dial tcp 172.28.15.241:64434: connect: connection refused

If somebody is updating stand in parallel you'll get:

[🤬 aka FATAL]: one of goroutines in waitgroup sent error: 8 errors occurred:
	* failed to fix "session-data-t846-0b9ed@testing-t846-0b9ed-apps" pending status: release is in pending status
	* failed to fix "security-t846-0b9ed@testing-t846-0b9ed-secr" pending status: release is in pending status
	* failed to fix "api-platform-t846-0b9ed@testing-t846-0b9ed-apps" pending status: release is in pending status
	* failed to fix "billing-t846-0b9ed@testing-t846-0b9ed-apps" pending status: release is in pending status
	* failed to fix "authentication-t846-0b9ed@testing-t846-0b9ed-apps" pending status: release is in pending status
	* failed to fix "observability-t846-0b9ed@testing-t846-0b9ed-infra" pending status: release is in pending status
	* failed to fix "appl-t846-0b9ed@testing-t846-0b9ed-apps" pending status: release is in pending status
	* failed to fix "notification-t846-0b9ed@testing-t846-0b9ed-apps" pending status: release is in pending status

For incompatible chart changes It fails with:

[💩 aka ERROR]: ❌ can't get manifests: failed to upgrade home-page-demo-tp@demo-tp-infra: rendered manifests contain a resource that already exists. Unable to continue with update: Ingress "home-page-demo-tp-dbp-home-page-ing" in namespace "demo-tp-infra" exists and cannot be imported into the current release: invalid ownership metadata; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "home-page-demo-tp"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "demo-tp-infra"

Even running with --diff-mode local does not help in all of the cases above.

** General info (please complete the following information):**

  • OS: verified on Linux and Windows
  • Helmwave Version 0.24.3

To Reproduce
Steps to reproduce the behavior:

  1. Break contents of your KUBE_CONFIG
  2. Try to run helmwave build --yml --diff-mode local for any of your Helmwave manifests
  3. You will get an error: I can't check if release is installed

Expected behavior
There should be a way of running helmwave build without building diff and making any requests to K8S API.
It is useful for the sake of linting and verifying Helmwave manifests.
In our team several engineers can edit Helmwave manifests in parallel and if somebody runs helmwave up all others should wait for 20 minutes before testing their changes with linters because they can't get a successful helmwave build.

@Blobson Blobson added the bug Something isn't working label Jan 16, 2023
@stale
Copy link

stale bot commented Apr 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 18, 2023
@repo-ranger
Copy link

repo-ranger bot commented Apr 18, 2023

⚠️ This has been marked to be closed in 7 days.

@zhilyaev zhilyaev added this to the v0.26.0 milestone Apr 19, 2023
@repo-ranger repo-ranger bot closed this as completed Apr 25, 2023
@zhilyaev zhilyaev reopened this Jun 7, 2023
@stale stale bot removed the wontfix This will not be worked on label Jun 7, 2023
@zhilyaev
Copy link
Member

zhilyaev commented Jun 7, 2023

will fix in #611

@zhilyaev zhilyaev closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

2 participants