Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically set offline_kube_version for charts with CRDs used #675

Closed
r3nic1e opened this issue Aug 4, 2023 · 0 comments · Fixed by #676 or #677
Closed

Automatically set offline_kube_version for charts with CRDs used #675

r3nic1e opened this issue Aug 4, 2023 · 0 comments · Fixed by #676 or #677
Assignees

Comments

@r3nic1e
Copy link
Member

r3nic1e commented Aug 4, 2023

Imagine we try to install kube-prometheus-stack. It has some CRDs defined and also some resources that use it.
Since we try to run dry-run install to get manifests, it fails (no CRDs are deployed yet).

Right now there is one workaround for this: offline_kube_version. It is required only during first install.

The proposal is:

  • Either automatically enable offline_kube_version if we get the error and retry
  • Or discover CRDs in the release and try to hack kube mapping to include those CRDs
@zhilyaev zhilyaev self-assigned this Aug 4, 2023
This was linked to pull requests Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants