This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Fix modal body to adapt height based on content, on IE11 #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix modal body to adapt height based on content, on IE11
On IE11, a modal is not adjusting his height based on the content. I think it's becaused of the shorthand version of
flex: 1. IE10-11 are interpolating that value the wrong waySetting it to
flex: 1 1 autofixed the issue I was havingThere are other places in Blue that used the same shorthand flex property. I didn't want to go in there and change everything without causing unknown side effects