Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collision with seneca #3

Closed
sberryman opened this issue Jun 8, 2017 · 1 comment
Closed

Collision with seneca #3

sberryman opened this issue Jun 8, 2017 · 1 comment

Comments

@sberryman
Copy link

I'm currently using seneca and would like to try out hemera from the same hapi server (for a few routes) but I'm running into an issue with decorations as seneca is already defining them (via Chairo)

(node:9810) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: Server decoration already defined: action

What do you think about extending internals.defaults with an option to disable hapi decorations. Obviously this would be disabled/false by default.

Then we can check the options before decorating hapi. I'll do a quick PR if you think this makes sense for the general hemera community.
@sberryman sberryman mentioned this issue Jun 8, 2017
Closed
@StarpTech
Copy link
Member

PR was closed due to inactivity and issue was fixed with #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sberryman @StarpTech