New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Hapi Dependencies #243
Conversation
The Travis CI has failed due to dependency updates using new features of JavaScript that aren't supported in Node 6. Should we consider dropping support for Node 6 as it reached end of life on 2019-04-30? https://github.com/nodejs/Release#release-schedule |
@jackieluc - dropping Node6 support was one of starptech's stated goals. |
Hi @jackieluc thank you for the PR. This PR can't be merged as long as we support Node.js 6 which will introduce a breaking change. |
@StarpTech - if we resubmit this PR with node 6 removed, is this a helpful contribution towards hemera@8? We're open to being coached / advised how we can best contribute. Thank you. |
This PR hasn't a single purpose. There are too many breaking changes. Please create several PR's.
Yes, if it really contains only a dependency update. I will create a branch called |
Its my bad for making a PR without checking Node 6 support first - though it seems like the migrated Hapi dependencies do not support Node 6. I agree that this PR would be more productive if it were to be included in the next major version of Hemera that drops support for unsupported Node versions. |
Hello @StarpTech - I propose that this is a singular purpose PR based on the following rationale: This PR resolves all hapi family component deprecation warnings. (Dropping of Node6 support is also implied to affect this.) Otherwise, the existing functional contract is unchanged. So, breaking change for dropping Node6 - yes. Otherwise, no breaking change. And, in a subsequent PR, we'll add Node@12 support (though I have not even looked at that yet). |
@momiller121 that's not correct. Following changes are breaking changes beside to support new hapi modules:
@jackieluc please create different PR's for that and merge against |
@StarpTech - I see that now. Thank you. We'll reformulate against the |
I really appreciate that PR but I think it's not worth it. I will update all dependencies in a batch. In the next days, I will assign several issues to the milestone |
Hi @StarpTech,
The following
hapi
packages have been deprecated and have been migrated under thehapi
organization. I thought it would be great to migrate them (so they continue to be supported) and update the dependencies.I also bumped the versions of each of the following packages that were affected by a minor version (following semver). Please advise if you'd like things to be different.