Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] ARM support #158

Closed
mxmeeple opened this issue Feb 17, 2023 · 5 comments
Closed

[FEATURE] ARM support #158

mxmeeple opened this issue Feb 17, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@mxmeeple
Copy link
Contributor

mxmeeple commented Feb 17, 2023 •
edited
Loading

Description

It would be nice to support ARM architecture, for those running things like the RasPi
I believe this would be easy to do with the github workflow actions by just adding docker/setup-buildx-action, docker/setup-qemu-action and using the platform tag on docker build

Screenshots

No response

Additional information

Tested in a fork
@mxmeeple mxmeeple added the enhancement New feature or request label Feb 17, 2023
@bjarneo
Copy link
Member

bjarneo commented Feb 17, 2023

Feel free to open a PR if you have something ready 😁

@mxmeeple
Copy link
Contributor Author

(Sorry that was a mis-click, to close)
Linking to my PR #159

@mxmeeple mxmeeple reopened this Feb 18, 2023
@bjarneo
Copy link
Member

bjarneo commented Feb 19, 2023

Thank you for your PR! 🚀

@bjarneo bjarneo closed this as completed Feb 19, 2023
@bjarneo
Copy link
Member

bjarneo commented Feb 19, 2023

I did this change to reduce the size of the docker images: 9d0f91a

which means for the ARM images you need to prepend the prefix arm- to use them

@bjarneo
Copy link
Member

bjarneo commented Feb 19, 2023

On a second though I might misunderstand how this works, so they could just be the same image. I have to read up on docker platforms 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjarneo @mxmeeple