Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Navigation Drawer #23

Closed
schott12521 opened this issue Apr 3, 2018 · 10 comments
Closed

Issues with Navigation Drawer #23

schott12521 opened this issue Apr 3, 2018 · 10 comments

Comments

@schott12521
Copy link

Using this library, my toolbar will hide the navigation drawer hamburger icon when the toolbar is collapsed. Unsure of what could be causing this.

@hendraanggrian
Copy link
Owner

I have some guesses, but it's difficult to pick one without knowing more:

  1. Are you using action toggle from support v7 library?
  2. Are you absolutely sure that such behavior does not appear if you replace SubtitleCollapsingToolbarLayout with regular CollapsingToolbarLayout?
  3. Your phone/emulator OS version and support library version you're using.

@schott12521
Copy link
Author

Sure thing, thanks for the quick response!

  1. I am using action toggle, specifically: ActionBarDrawerToggle
  2. Correct, when using a regular CollapsingToolbarLayout the hamburger icon persisted in the upper left of the action bar regardless or collapsed or expanded state.
  3. I am on an OG Pixel XL with Oreo 8.1 and using 27.1.0 support library version

@hendraanggrian
Copy link
Owner

hendraanggrian commented Apr 3, 2018

  1. The thing is, there's 2 versions of ActionBarDrawerToggle, one from android.support.v4.app and another from android.support.v7.app. Which one are you using?
  2. If you replace it with regular back arrow icon (?homeAsUpIndicator attribute). Does the back arrow still behaves the same way? Just wanna make sure if the issue is related to action bar toggle at all.

@schott12521
Copy link
Author

schott12521 commented Apr 3, 2018

  1. I'm using android.support.v7.app.ActionBarDrawerToggle
  2. Yes, the same issue happens with just homeAsUp Enabled as well

I can still click where the hamburger should be and expand the nav drawer, it is not visible though.

@hendraanggrian
Copy link
Owner

This is news to me, I'll try it myself and will get back to you with the result in couple days (sorry, I'm currently working on other libraries).

@schott12521
Copy link
Author

Alright sounds great, let me know if I can be of any assistance. The only thing that might help so far is that I was looking at the Debug Overdraw screen and with the normal Collapsing Layout, the title warps from being a box of the full width of the device, to just the width of the text. That does not happen with the Subtitle Collapsing Layout, so maybe we need to change the width? Thank you!

@hendraanggrian
Copy link
Owner

Hi, I've tested example app with back icon (homeAsUpIndicator) enabled:

screenshot_1523203661
screenshot_1523203667

Safe to say I am unable to recreate the issue you are experiencing. Could you please screenshoot your screen?

@schott12521
Copy link
Author

schott12521 commented Apr 10, 2018

Sure! Here is my expanded view: Expanded

and here is my collapsed: Collapsed

I'm not doing anything special with my subtitle collapsing layout, its more or less a standard / out of the box setup. Pixel OG, Android 8.1.0 latest security patch. I will try to get a video of collapsing and what it looks like so maybe we can use that to bug fix? Let me know what else I can do to help.

Are you able to get it to work with a navigation hamburger as well or just the homeAsUpIndicator?

Also of note is that I have the same problem without the nav drawer, the back arrow is covered as well if I have setHomeAsUpIndicator enabled.

@schott12521
Copy link
Author

Damn. Its the little things that can really mess up your development, lol. My issue was that I was setting:

android:paddingBottom="50dp"

which was hiding the icon. Thanks for all of the assistance / great library!

@hendraanggrian
Copy link
Owner

Cool! Let me know when you experience other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants