Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The way of evaluation #3

Closed
liun-online opened this issue Mar 9, 2022 · 2 comments
Closed

The way of evaluation #3

liun-online opened this issue Mar 9, 2022 · 2 comments

Comments

@liun-online
Copy link

Hi, author ! Thanks for your code! But I have a puzzle about the evaluation. In 147~150 lines of main.py, you first decide if the new val_acc is bigger than original one. If this condition is satisfied, you then decide the test_acc in the same way. However, during the training of logreg, the test shouldn't be used in my opinion, while only validation is ok. Is there any problem?

@hengruizhang98
Copy link
Owner

See this issue #2

@liun-online
Copy link
Author

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants