Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Update cwd on cd #42

Closed
derekr opened this issue Mar 10, 2017 · 13 comments
Closed

Update cwd on cd #42

derekr opened this issue Mar 10, 2017 · 13 comments

Comments

@derekr
Copy link

derekr commented Mar 10, 2017

Looks like it only updates on session based events. I'd expect the cwd to update on changing directories as well.

@henrikruscon
Copy link
Owner

It should. It's not working for you? ✌️

@derekr
Copy link
Author

derekr commented Mar 10, 2017

Yeah using zsh + hyper 1.3.1 I'm not seeing an update until I trigger a session related event like double clicking the current tab or opening a new tab and navigating back.

statusline

config

module.exports = {
  config: {
    // default font size in pixels for all tabs
    fontSize: 12,

    // font family with optional fallbacks
    fontFamily: 'Menlo, "DejaVu Sans Mono", Consolas, "Lucida Console", monospace',

    // terminal cursor background color and opacity (hex, rgb, hsl, hsv, hwb or cmyk)
    cursorColor: 'rgba(248,28,229,0.8)',

    // `BEAM` for |, `UNDERLINE` for _, `BLOCK` for █
    cursorShape: 'BLOCK',

    // color of the text
    foregroundColor: '#fff',

    // terminal background color
    backgroundColor: '#000',

    // border color (window, tabs)
    borderColor: '#333',

    // custom css to embed in the main window
    css: '',

    // custom css to embed in the terminal window
    termCSS: '',

    // set to `true` if you're using a Linux set up
    // that doesn't shows native menus
    // default: `false` on Linux, `true` on Windows (ignored on macOS)
    showHamburgerMenu: '',

    // set to `false` if you want to hide the minimize, maximize and close buttons
    // additionally, set to `'left'` if you want them on the left, like in Ubuntu
    // default: `true` on windows and Linux (ignored on macOS)
    showWindowControls: '',

    // custom padding (css format, i.e.: `top right bottom left`)
    padding: '12px 14px',

    // the full list. if you're going to provide the full color palette,
    // including the 6 x 6 color cubes and the grayscale map, just provide
    // an array here instead of a color map object
    colors: {
      black: '#000000',
      red: '#ff0000',
      green: '#33ff00',
      yellow: '#ffff00',
      blue: '#0066ff',
      magenta: '#cc00ff',
      cyan: '#00ffff',
      white: '#d0d0d0',
      lightBlack: '#808080',
      lightRed: '#ff0000',
      lightGreen: '#33ff00',
      lightYellow: '#ffff00',
      lightBlue: '#0066ff',
      lightMagenta: '#cc00ff',
      lightCyan: '#00ffff',
      lightWhite: '#ffffff'
    },

    // the shell to run when spawning a new session (i.e. /usr/local/bin/fish)
    // if left empty, your system's login shell will be used by default
    shell: 'zsh',

    // for setting shell arguments (i.e. for using interactive shellArgs: ['-i'])
    // by default ['--login'] will be used
    shellArgs: ['--login'],

    // for environment variables
    env: {},

    // set to false for no bell
    bell: 'SOUND',

    // if true, selected text will automatically be copied to the clipboard
    copyOnSelect: false

    // URL to custom bell
    // bellSoundURL: 'http://example.com/bell.mp3',

    // for advanced config flags please refer to https://hyper.is/#cfg
  },

  // a list of plugins to fetch and install from npm
  // format: [@org/]project[#version]
  // examples:
  //   `hyperpower`
  //   `@company/project`
  //   `project#1.0.1`
  plugins: [
    'hyper-pane',
    'hyperlayout',
    'hyper-statusline',
    'hyperterm-firewatch'
  ],

  // in development, you can create a directory under
  // `~/.hyper_plugins/local/` and include it here
  // to load it and avoid it being `npm install`ed
  localPlugins: []
};

@henrikruscon
Copy link
Owner

henrikruscon commented Mar 10, 2017

vercel/hyper@fe6e297 was introduced in Hyper 1.3.0 which affected hyper-statusline's code that looks for cmd closure.

So hyper-statusline was updated accordingly.

Make sure you're running >= 1.3.0 and latest hyper-statusline version as well ✌️

Edit: If that's still not working then you can try the debug branch https://github.com/henrikdahl/hyper-statusline/tree/debug and check your console output when you press the enter key

@aryzing
Copy link

aryzing commented Mar 10, 2017

I'm on hyper 1.3.1, and I'm having the same issue: only updating directory on click events. I'm on the latest version of statusline too.

@henrikruscon
Copy link
Owner

@aryzing mind trying the debug branch?

@aryzing
Copy link

aryzing commented Mar 11, 2017

Sure, I'll try it out. I'll need instructions though...

@henrikruscon
Copy link
Owner

henrikruscon commented Mar 11, 2017

@aryzing you can just clone the fork into your ~/.hyper_plugins and put hyper-statusline in your local part of your .hyper.js config.

Then it's supposed to output a char code in the console and that's what I need from you ✌️

@aryzing
Copy link

aryzing commented Mar 11, 2017

When moving from ~ to the dir that has my work, these are all the charCodes emitted:

charCode:99
charCode:100
charCode:32
charCode:119
charCode:111
charCode:114
charCode:116
charCode:113
charCode:45
charCode:13

Which correspond to the keystrokes cd<tab>wo<tab>tq<tab><enter>

Hope that helps!

PD. Also, a more detailed description of what I did in case anyone else wants to try

cd ~/.hyper_plugins/local
git clone git@github.com:henrikdahl/hyper-statusline.git
git checkout debug
npm i

Then edited ~/.hyper.js and moved 'hyper-statusline' from plugins to localPlugins array, and restarted.

@henrikruscon
Copy link
Owner

That's odd. Your enter charCode is 13 while mine is 27 🤔

@henrikruscon
Copy link
Owner

henrikruscon commented Mar 11, 2017

@aryzing I just pushed a new version to debug, would you mind trying it? Thanks!

It's using a more reliable method to check for enter key instead of charCode. Console log should output if the enter key is true or false.

@aryzing
Copy link

aryzing commented Mar 11, 2017

It's working now, output:

enterKey:true
10 enterKey:false
enterKey:true

Thanks!

@aryzing
Copy link

aryzing commented Mar 11, 2017

Btw, that 10 is the dev tools bundling up a bunch of console.logs

@henrikruscon
Copy link
Owner

Thanks for your help! Just pushed it to master ✌️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants