Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method overloads in modules for methods with optional parameters #404

Open
henrikfroehling opened this issue Jan 29, 2023 · 0 comments

Comments

@henrikfroehling
Copy link
Owner

For example:

public Task<TraktResponse<ITraktShow>> ITraktShowsModule.GetShowAsync(
    string showIdOrSlug, TraktExtendedInfo extendedInfo = null,
    CancellationToken cancellationToken = default);

should be split up into

public Task<TraktResponse<ITraktShow>> ITraktShowsModule.GetShowAsync(
    string showIdOrSlug, CancellationToken cancellationToken = default);

and

public Task<TraktResponse<ITraktShow>> ITraktShowsModule.GetShowAsync(
    string showIdOrSlug, TraktExtendedInfo extendedInfo,
    CancellationToken cancellationToken = default);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Open
Development

No branches or pull requests

1 participant