Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor System.exit into return codes #1

Open
9 tasks done
henrikglass opened this issue Feb 27, 2019 · 6 comments
Open
9 tasks done

Refactor System.exit into return codes #1

henrikglass opened this issue Feb 27, 2019 · 6 comments
Assignees

Comments

@henrikglass
Copy link
Owner

henrikglass commented Feb 27, 2019

See: cyrille-artho#27

In MBT.scala (line numbers):

In Modbat.scala

  • 237 @Pandington

In Dotify.scala

Pick some.

@henrikglass henrikglass self-assigned this Feb 27, 2019
@henrikglass
Copy link
Owner Author

I'm taking 216, 253 and 272.

@btellstrom
Copy link
Collaborator

I'll take 278 and 292

@A1337li
Copy link
Collaborator

A1337li commented Feb 27, 2019

I'll take 309

@ffsinger
Copy link
Collaborator

Taking 455 and 237

@btellstrom btellstrom self-assigned this Feb 27, 2019
@A1337li A1337li self-assigned this Feb 27, 2019
@ffsinger ffsinger self-assigned this Feb 27, 2019
@henrikglass
Copy link
Owner Author

I added a "System.exit(1)" in Modbat.wrapRun. We need to change that to a return as well.

@ffsinger
Copy link
Collaborator

Lines 237 and 209 actually don't seem to need any change, the functions already return an exit code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants