Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed feature #2 - Change the Mask #3

Closed
roc-eab opened this issue Dec 1, 2022 · 3 comments
Closed

Proposed feature #2 - Change the Mask #3

roc-eab opened this issue Dec 1, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@roc-eab
Copy link

roc-eab commented Dec 1, 2022

Rarely used features, however if feasible would it be possible adding to the "rdb part add" the mask option?

I have spoiled it in the code with the default value 2147483646 (7ffffffe) which is used in most cases for hard disk images.

The usage that comes to my mind is for images meant for CF cards, where the 0xfffffe mask is used instead of the 0x7ffffffe

Thank you for considering this.

@henrikstengaard
Copy link
Owner

I can add support for setting mask when adding a partition.

Should also be added for part update as well.

@henrikstengaard henrikstengaard self-assigned this Dec 1, 2022
@henrikstengaard henrikstengaard added the enhancement New feature or request label Dec 1, 2022
@henrikstengaard
Copy link
Owner

New release adds mask option to both rdb part add and update commands and supports either integer value or hex value, so e.g. max transfer can be set to integer value 130560 or hex value 0x1fe00.

@roc-eab
Copy link
Author

roc-eab commented Dec 4, 2022

It works well, thanks!

@roc-eab roc-eab closed this as completed Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants