New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the statusBar color #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for your contribution.
I added a few review comments that must be addressed before we can merge this PR.
There is also a unexpected behaviour happening after splash screen disappears: the status bar color remains the splash color. This is happening because color is changed in MainActivity and is not changed back.
This is not caused specifically by your PR but using a custom color on status bar makes it more visible, so we also need to address that.
Thanks again for your contribution. If you can make changes in order to fix those issues I would really appreciate that, otherwise I will look into this in a few days (as soon as I have time!)
Issues from the review are fixed and this is now available in v0.1.8+1. SDK version check is now on Java/Kotlin code as proposed by @yaymalaga. Thanks guys! |
@henriquearthur thank you for fixing the issue sorry didn't had the time to fix it had a hectic week at work :) |
Before the plugins set the status bar color to white. As a consequence, it overrides the status bar color defined by the material swatches.
I looked in the Flutter source code to look for how they generate the material color swatch used the same principles to generate the material color dark for every color