Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can support audio file? #12

Closed
pepperdog999 opened this issue Jul 6, 2018 · 7 comments
Closed

can support audio file? #12

pepperdog999 opened this issue Jul 6, 2018 · 7 comments

Comments

@pepperdog999
Copy link

can support audio file?

@henrygd
Copy link
Owner

henrygd commented Jul 7, 2018

No but here's a version that supports audio (tested only on chrome and firefox):

https://codesandbox.io/s/k57433qyv

@henrygd henrygd closed this as completed Jul 7, 2018
@cayasso
Copy link

cayasso commented Aug 6, 2018

Hi @henrygd , is there a possibility that audio can be supported in the core, or is there any reason you didn't add audio ? I have a use case at my company were an mp4 can be just audio file, in that case it would be very useful to just load it using this same library.

BTW. The audio files are loading with the audio look and field already so I am not sure this is a fallback behavior of the html5 video tag, which is so cool, but I am not sure if all browser has this same behavior so it would be great if it this can be officially supported by this lib.

Thanks!

image

@henrygd
Copy link
Owner

henrygd commented Aug 7, 2018

@cayasso Sure, I'll try to add an audio option this weekend.

In your case do you know ahead of time which mp4 files are meant as audio and which are video?

@henrygd
Copy link
Owner

henrygd commented Aug 12, 2018

Should have this updated in the next couple of days. Safari is acting weird in browserstack so I need to test on my computer at work.

@cayasso
Copy link

cayasso commented Aug 12, 2018

So awesome! thank you for be adding this feature @henrygd.
To your question above, yes I know ahead of time which is audio and which is going to be a video with a flag, I am not sure if there is a way to do this programmatically but for sure crome seems to know when its only audio or video+audio.

@henrygd
Copy link
Owner

henrygd commented Aug 14, 2018

Finally got this sorted: e1813be

@cayasso Let me know if you have any trouble

@cayasso
Copy link

cayasso commented Aug 15, 2018

Hey @henrygd I took some time to test the audio feature and it is working like a charm, nice job, now I think this library is media complete ;-) thanks for the so quick turn around on this. I will be using it in my project https://spry.cr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants