New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to unzip chromium when the 7z file come from the standard build process #166
Comments
Hello, i understand that and can help you if you can tell me why official builds ("dev-official" etc.) do not have this double-packing archive structure ( It's poor and useless - it will bloat-packed because zipping of zip file do not more compression, but adds additional information for unpacking, so chrlauncher can unpack only 1 archive ( |
Ok. Currently, all works. |
@henrypp, it's not that poor and useless, official installers use double-packing structure If inner But the difference between zip and 7z is a lot more significant, and copying official procedure would result in a much larger output. |
Who knows, try asking Chromium developers or building one yourself with |
Hello Henry,
I know that my title is not very clear! ;)
I prefer to show the comments on my site relative to this issue. (These links will show all comments).
https://chromium.woolyss.com/?all=1#comment-5180
and https://chromium.woolyss.com/?all=1#comment-5370
Hibbiki, the developer of stable Chromium version on Windows says :
Henry, to help you, I prepared 2 chrlauncher archives to test! ^^
https://chromium.woolyss.com/f/chrlauncher-win64-stable-codecs-sync.zip
This chrlauncher will download the chromium release of Hibbikki.
Here, Hibbikki has modified his Chromium build process to be compatible with chrlauncher.
Result: It works but the standard build process of Chromium is not respected.
For info, API url: https://chromium.woolyss.com/api/v3/?os=windows&out=json&type=stable-codecs-sync
https://chromium.woolyss.com/f/chrlauncher-win64-stable-codecs-sync-78.zip
This chrlauncher will download the chromium v78 release of Hibbikki.
Here, Hibbikki used the standard Chromium build process.
Result: chrlauncher cannot unzip it because it does not know its file structure.
For info, API url: https://chromium.woolyss.com/api/v3/?os=windows&out=json&type=stable-codecs-sync-78
So please, is it possible for you to improve chrlauncher about unzip process?
The best thing I see is when chrlauncher see a zip or 7z archive file, it automatically unzip it until there is no archive file inside. Limit the recursivity to 2 unzipped processes should be enough.
What do you think? Is it possible?
The text was updated successfully, but these errors were encountered: