Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for ungoogled-chromium #33

Closed
rodneyrod opened this issue Sep 26, 2016 · 16 comments
Closed

[Feature Request] Add support for ungoogled-chromium #33

rodneyrod opened this issue Sep 26, 2016 · 16 comments
Labels

Comments

@rodneyrod
Copy link

https://github.com/Eloston/ungoogled-chromium

@woolyss
Copy link

woolyss commented Sep 26, 2016

I know this set of patches since December 16, 2015 and do not understand why there is a buzz today (maybe 'cause Hacker News topic: https://news.ycombinator.com/item?id=12577787)! ^^
Check my site archive dated in 2015, in the "News --> Found on the Web" section at https://web.archive.org/web/20151219081240/http://chromium.woolyss.com ("Patches for Google Chromium to remove integration with Google services and add additional features"). Other site archive on https://archive.is/pWzpw ;)

Nik does not compile Chromium with them.

  1. First reason:
    Check the Nik answer at https://chromium.woolyss.com/?all=1#comment-995 (March 2016)
    (this link will display ALL comments. It can be slow to display!)

  2. Second reason:
    Nik and me want to keep "Chromium as Chromium".
    It means there are already other Chromium forks using similar patches. So why to redo another browser?
    Iridium Browser, Brave Browser, Comodo Dragon, SRWare Iron, Epic Browser...
    More at https://chromium.woolyss.com/#browsers

Regards

@henrypp
Copy link
Owner

henrypp commented Sep 26, 2016

@woolyss, so question to you: can you add possibility to your api for download ungoogled chromium from chrlauncher?

@woolyss
Copy link

woolyss commented Sep 26, 2016

Sure I see Windows binaries at https://github.com/Eloston/ungoogled-chromium/releases but I see also many bugs about privacy (relative to the project) https://github.com/Eloston/ungoogled-chromium/issues and know that Chromium source code changes very often. Eloston, the developer, can he follow each changes in Chromium source code (relative to his project, obviously)?

About my API. Yes, all is possible. But is it interesting for users?
Windows binaries are only in 32-bit version (without PGO enabled). Note the first Windows version started in August 11, 2016. So it is a very young project.

I follow this project and test an entry in my API ;)

@rodneyrod
Copy link
Author

@woolyss Thank you for this, I know it's outside the scope of your project, but it would greatly assist users in deploying ungoogled-chromium on their systems, especially those who need a portable setup.

@woolyss
Copy link

woolyss commented Oct 4, 2016

Please, can you test new releases of 64-bit chromium with ungoogled-chromium patches?
https://chromium.woolyss.com/#windows-64-bit

@leeoniya
Copy link

leeoniya commented Oct 4, 2016

cool! i'll test as well.

any plans on eventually building ungoogled dev versions? (55.x)

@woolyss
Copy link

woolyss commented Oct 4, 2016

@leeoniya: > dev versions? (55.x)
In short, these patches are for stable versions.
https://github.com/Eloston/ungoogled-chromium/blob/master/version.ini

More info:
Some of patches are not working because they are for GYP build system (fix-building-without-one-click-signin.patch and others). Nik, our developer uses GN build system. It is faster than GYP ;)
List of all patches: https://github.com/Eloston/ungoogled-chromium/blob/master/resources/common/patches/patch_order

@leeoniya
Copy link

leeoniya commented Oct 6, 2016

couple things i've run into so far:

  • Chrome extensions are not installable from store (there's no Add to Chrome button), eg [1]. For uMatrix and uBlock Origin, i can install them i developer mode if i download & unpack from the github repos, but I imagine most extensions dont provide an easy way to grab these zips/crxs/whatever. Also, it means i'm on my own for keeping these extensions constantly updated which could be a security risk.
  • Clicking "Get more extensions", at the bottom of the extensions page which points to https://chrome.9oo91e.qjz9zk/webstore/category/extensions?hl=en-US results in "Blocked attempted request to: ..."
  • The following are pre-installed and appear to be non-removable from the extension manager: Bookmark Manager, Chromium PDF Viewer (isn't this a binary, closed-source blob?), CryptoTokenExtension. (This extension is managed and cannot be removed or disabled.)

[1] https://chrome.google.com/webstore/detail/ublock-origin/cjpalhdlnbpafiamejdnhcphjbkeiagm?hl=en

@woolyss
Copy link

woolyss commented Oct 6, 2016

@leeoniya, thank you for feedback!

Chrome extensions are not installable from store

FAQ of ungoogled-chromium: https://github.com/Eloston/ungoogled-chromium/blob/master/FAQ.md
You can use other ways: https://chromium.woolyss.com/#external-extension-installation

Chromium PDF Viewer [...] closed-source?

No. PDFium is open-source like other pre-installed addons:
https://pdfium.googlesource.com/pdfium/
https://en.wikipedia.org/wiki/Talk%3AList_of_PDF_software#PDFium

CryptoTokenExtension: https://chromium.googlesource.com/chromium/src.git/+/master/chrome/browser/resources/cryptotoken/

@leeoniya
Copy link

leeoniya commented Oct 6, 2016

You can use other ways: https://chromium.woolyss.com/#external-extension-installation

It would be really useful if chrlauncher could do most (if not all) of this for me (if i enable some extension-auto-update flag). It's simply not practical to do this manually using third-party utils to keep everything updated.

No. It is PDFium: https://pdfium.googlesource.com/pdfium/

Still, i should be able to choose another viewer like PDF.js, so it should be removable or at least disable-able? A build without WideVine would be welcome, too.

Do all these extensions already exist in normal Chromium but are hidden from the list because they're "Managed" and ungoogled just unhides them and shows you the reality?

@woolyss
Copy link

woolyss commented Oct 6, 2016

if chrlauncher could do most

I do no know if henrypp will improve chrlauncher in this direction.

On ungoogled-chromium, you cannot remove default addons.
https://i.imgur.com/SrrF8Dy.png

But you can disable Chromium PDF Viewer on chrome://plugins
Install another PDF viewer extension now! ;)

Tested on:
32-bit version: https://github.com/Eloston/ungoogled-chromium/releases/tag/53.0.2785.116-1
64-bit version: https://chromium.woolyss.com/#windows-64-bit-test-nik
Same result!

ungoogled-chromium is not our (nik and me) project. So, it is difficult to help you ;)
Eloston plans to do a 64-bit version: ungoogled-software/ungoogled-chromium#62 (comment)

For more, follow the official project and check FAQ at https://github.com/Eloston/ungoogled-chromium/blob/master/FAQ.md

Tha main thing I can do is to add ungoogled-chromium to chrlauncher (via my API).

Regards,

@fbis251
Copy link

fbis251 commented Jan 2, 2017

ungoogled-chromium has received a lot of updates since October and it seems like there aren't any major issues with it anymore.

@woolyss would it be possible to add ungoogled-chromium to your site again to enable chrlauncher to auto update it?

@woolyss
Copy link

woolyss commented Jan 2, 2017

@fbis251 Yes. It is possible. I prepares that.

@fbis251
Copy link

fbis251 commented Jan 24, 2017

@woolyss Don't mean to be a bother but have you had a chance to look at adding ungoogled-chromium?

@henrypp
Copy link
Owner

henrypp commented Feb 14, 2017

see 2.3

@henrypp henrypp closed this as completed Feb 14, 2017
@woolyss
Copy link

woolyss commented Feb 14, 2017

@henrypp: Thank you very much Henry. You are the man! ;)

Quick explanation for new users:
ungoogled-chromium is now supported by the free and open-source chrlauncher.

So now chrlauncher can install, automatically update and launch Chromium and ungoogled-chromium on Windows 7, 8.1 and 10.

It is also possible to use ungoogled-chromium as a portable version. ^^

All works nicely with the latest chrlauncher version (v2.3 currently!)
https://github.com/henrypp/chrlauncher/releases

For info, API used for update, by chrlauncher:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants