Further improve UX, feature update, implement editor functions #14
Conversation
henryzt
commented
Jun 10, 2020
henryzt
commented
- User authentication logic update, default anonymous login
- Implement result uploading and display
- Game start logic update
- Refactor visualizer, making it pluggable and modular
- Implement sheet editor
| data: function(){ | ||
| return { | ||
| } | ||
| }, |
There was a problem hiding this comment.
Yes but I left there for future use lmao (better not tho), will be cleaned at some point. Or now...
| okText: undefined, | ||
| cancelText: undefined, | ||
| titleText: undefined, | ||
| bodyText: undefined, |
There was a problem hiding this comment.
| okText: undefined, | |
| cancelText: undefined, | |
| titleText: undefined, | |
| bodyText: undefined, | |
| okText: null, | |
| cancelText: null, | |
| titleText: null, | |
| bodyText: null, |
There was a problem hiding this comment.
This is actually intended, as vue would consider undefined to, you know, undefined. If I pass null it will indeed clear all the display text to null, which is not what I wanted. Is it ok to set vars be undefined?
src/javascript/db.js
Outdated
| function clean(obj) { | ||
| for (let propName in obj) { | ||
| if (obj[propName] === null || obj[propName] === undefined) { | ||
| delete obj[propName]; | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This seems... peculiar. Why exactly is this needed?
There was a problem hiding this comment.
Well this is used before firebase's update document command, which will overwrite the existing db document. I would like to remove any null attribute to prevent any desired value to be overwritten. However this might also make the user unable to make the field they intended to make blank though...
This also produces an ES lint Error for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array no-restricted-syntax
Do you have any idea to solve this better?
There was a problem hiding this comment.
If the attribute already has a null value, then why shouldn't it be updated? Unless this is how firebase designs their API? Asking since I'm not familiar with firebase.
There was a problem hiding this comment.
It's the other way around, if the attribute has data, should null overwrite it or not, is null intended by the user or not. I might need to find a better solution T T
Ohhhhhhhhhhhhhhhh that's why! I thought it's vue doesn't support those... |
Co-authored-by: 许杰友 Jieyou Xu (Joe) <39484203+jieyouxu@users.noreply.github.com>
