Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悶 BugFix CardIo::GetCardUID - Iso14443-3 MifareClassic cards with UID length > 8 cropped #5

Open
Rikj000 opened this issue Feb 23, 2024 · 1 comment 路 May be fixed by #6
Open

馃悶 BugFix CardIo::GetCardUID - Iso14443-3 MifareClassic cards with UID length > 8 cropped #5

Rikj000 opened this issue Feb 23, 2024 · 1 comment 路 May be fixed by #6

Comments

@Rikj000
Copy link

Rikj000 commented Feb 23, 2024 •
edited

Description

Currently SnappyWinscard,
can only handle cards with a card UID length of 8 characters,
anything beyond this length is cropped off.

Environment

Name Version
SnappyWinscard 1.0.1.0-beta.1 (master @ f7e0b78)
Windows 11 Pro 22H2
Kernel 10.0.22621.0
MSBuild 17.0 (Visual Studio 2022)
Target Framework netstandard 2.0
@Rikj000 Rikj000 linked a pull request Mar 20, 2024 that will close this issue
Open
@Rikj000
Copy link
Author

Rikj000 commented Mar 20, 2024

With #6 you can support card UIDs of both 8 and 14 characters by doing something like:

var cardUid = _acsReader.GetCardUID(cardUidLength: 14).ToUpper();
if (cardUid.EndsWith(value: "900000")) {
    cardUid = cardUid.Substring(startIndex: 0, length: cardUid.Length - 6);
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

鈿★笍 Updated CardIo::GetCardUID - Support custom cardUidLength Rikj000/SnappyWinscard
1 participant
@Rikj000