Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root/yoda: parse 'value' given as a string of hyphen-separated bin limits #41

Open
GraemeWatt opened this issue Aug 19, 2021 · 0 comments
Labels

Comments

@GraemeWatt
Copy link
Member

If there are any non-numeric independent variable values, the current code uses bins of unit width and centred on integers (1, 2, 3, etc.) in the export to ROOT/YODA. There are some records (for example, here or here) where an incorrect YAML encoding has been used such as value: 800 - 1000 or value: '1-1.5' instead of separate low and high values. Such an incorrect YAML encoding gives an acceptable table rendering and is properly handled by the visualisation code, so it could easily be missed in the review process. We should therefore tolerate these incorrect YAML encodings in the export to ROOT/YODA by checking if a string value without explicit low and high values has the format of two numbers separated by a hyphen (with or without surrounding spaces). This case should then be treated in the same way as if separate low and high values were specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To do
Development

No branches or pull requests

1 participant