Include cron examples for schedule creation #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncdc
suggested changes
Feb 26, 2018
| ``` | ||
| ark create schedule --schedule="15 * * * *" bar | ||
| ``` | ||
| This would schedule a backup named `bar` that would run every fifteen minutes. |
There was a problem hiding this comment.
This runs at the 15th minute of every hour, not every 15 minutes
| | Character Position | Character Period | Acceptable Values | | ||
| | -------------------|:----------------:| -----------------:| | ||
| | 1 | Minute | 0-59,* | | ||
| | 2 | Hour | 0-23,* (UTC) | |
There was a problem hiding this comment.
I'm curious why you mention UTC here?
| @@ -7,10 +7,32 @@ Create a schedule | |||
|
|
|||
| Create a schedule | |||
|
|
|||
| The schedule period is a required flag. Notation for the schedule implements cron notation: | |||
There was a problem hiding this comment.
Maybe this?
The
--scheduleflag is required, in cron notation:
ncdc
reviewed
Feb 27, 2018
pkg/cmd/cli/schedule/create.go
Outdated
| | 4 | Month | 1-12,* | | ||
| | 5 | Day of Week | 0-7,* |`, | ||
|
|
||
| Example: `ark create schedule --schedule=0 */6 * * * foo`, |
There was a problem hiding this comment.
Need ' or " around the cron expression
|
FYI, we support everything our cron library does (https://godoc.org/github.com/robfig/cron#ParseStandard). |
Signed-off-by: Josh Hull <josh.hull@lypht.com>
|
LGTM. Thanks for the contribution @lypht!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Hull josh.hull@lypht.com