Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preStop hook for envoy is broken in v0.13.0 #1254

Closed
victornoel opened this issue Jul 19, 2019 · 3 comments · Fixed by #1256
Closed

preStop hook for envoy is broken in v0.13.0 #1254

victornoel opened this issue Jul 19, 2019 · 3 comments · Fixed by #1256
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
0.15.0

Comments

@victornoel
Copy link

Looking at the event logs of my kubernetes cluster, I see the following:

2m37s       Warning   FailedPreStopHook      Pod          Exec lifecycle hook ([wget -qO- --post-data='' http://localhost:9001/healthcheck/fail]) for Container "envoy" in Pod "contour-5484dfb84b-2czgv_proxy(9ee76b6b-a7ae-11e9-aa10-d690536598ee)" failed - error: command 'wget -qO- --post-data='' http://localhost:9001/healthcheck/fail' exited with 126: , message: "OCI runtime exec failed: exec failed: container_linux.go:344: starting container process caused \"exec: \\\"wget\\\": executable file not found in $PATH\": unknown\r\n"
@davecheney
Copy link
Contributor

Annoyingly the envoy image we recommend does not include wget or curl.

@davecheney davecheney added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jul 19, 2019
@davecheney davecheney added this to the 0.14.0 milestone Jul 19, 2019
davecheney added a commit to davecheney/contour that referenced this issue Jul 19, 2019
@davecheney
example: replace wget with bash magic
fcdd43d 
Fixes projectcontour#1254

Sadly envoyproxy/proxy does not ship with wget, or curl, so resort to
bash-fu to hit Envoy's healthcheck/fail endpoint.

Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney davecheney mentioned this issue Jul 19, 2019
Merged
@stevesloka stevesloka modified the milestones: 0.14.0, 0.15.0 Jul 21, 2019
@simonswine
Copy link

If the contour images contain curl/wget the preStop hook could also be called on the contour container. Might be more readable then the bash magic

@davecheney
Copy link
Contributor

@simonswine i'm not sure that will work as we're actively moving to split envoy and contour containers into their own pod.

davecheney added a commit to davecheney/contour that referenced this issue Aug 16, 2019
@davecheney
example: replace wget with bash magic
5978407 
Fixes projectcontour#1254

Sadly envoyproxy/proxy does not ship with wget, or curl, so resort to
bash-fu to hit Envoy's healthcheck/fail endpoint.

Signed-off-by: Dave Cheney <dave@cheney.net>
davecheney added a commit that referenced this issue Aug 16, 2019
@davecheney
example: replace wget with bash magic
a51b662 
Fixes #1254

Sadly envoyproxy/proxy does not ship with wget, or curl, so resort to
bash-fu to hit Envoy's healthcheck/fail endpoint.

Signed-off-by: Dave Cheney <dave@cheney.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
0.15.0
Development

Successfully merging a pull request may close this issue.

example: replace wget with bash magic davecheney/contour
4 participants
@davecheney @victornoel @simonswine @stevesloka