Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add how we work document #1082

Merged
merged 1 commit into from May 16, 2019
Merged

docs: add how we work document #1082

merged 1 commit into from May 16, 2019

Conversation

davecheney
Copy link
Contributor

The team is growing 馃帀 it seems like a good time to write down the way we work.

Signed-off-by: Dave Cheney dave@cheney.net

@davecheney davecheney added this to the 0.13.0 milestone May 13, 2019
@davecheney davecheney force-pushed the how-we-work branch 2 times, most recently from 61630b6 to 36bc248 Compare May 13, 2019 04:44
@davecheney davecheney requested a review from youngnick May 15, 2019 22:57
@davecheney
Copy link
Contributor Author

ping, still looking for a review.

stevesloka
stevesloka approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@stevesloka stevesloka left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM combined with the other contributing guide in the root covers it all.

The only other thing that I thought of would be adding something around using the fixes <issue> / updates <issue> to auto-close things.

youngnick
youngnick approved these changes May 16, 2019
View reviewed changes
Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are improvements to be made, but this is a great starting point.

@davecheney
docs: add how we work document
2b14055 
Signed-off-by: Dave Cheney <dave@cheney.net>
@davecheney
Copy link
Contributor Author

Cool. Thanks everyone for your input. As Nick pointed out, this is a starting point for a discussion, but you gotta start somewhere.

@davecheney
Copy link
Contributor Author

The only other thing that I thought of would be adding something around using the fixes / updates to auto-close things.

I'm sure that this is mentioned elsewhere in the CONTRIBUTING file. I'll make a note to double check.

@davecheney davecheney merged commit eb03247 into projectcontour:master May 16, 2019
@davecheney davecheney deleted the how-we-work branch May 16, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevesloka stevesloka stevesloka approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@davecheney @stevesloka @youngnick