This repository has been archived by the owner on Feb 27, 2023. It is now read-only.
Replace special char in openstack lb names when necessary and remove lb name validation #232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Given that we are no longer using the load balancer name as the discovered service/endpoint name, we no longer have skip load balancers that have invalid names.
However, the load balancer's name still ends up in a kubernetes label. Thus, we need to massage the load balancer name to a valid kubernetes label value.
Manual tests with openstack env
Created the following load balancers in openstack:
Discovered services:
Discovered endpoints:
Fixes #216