Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Add team docs with sample RBAC permissions #88

Merged
merged 2 commits into from May 7, 2018

Conversation

stevesloka
Copy link
Member

Fixes #85

Signed-off-by: Steve Sloka steves@heptio.com

Signed-off-by: Steve Sloka <steves@heptio.com>
Copy link
Contributor

@alexbrand alexbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Just one small nit.

docs/teams.md Outdated

## RBAC Rules

A key component of any secure Kubernetes cluster are permissions implemented via Role-Based Access Control (RBAC). Following is a sample RBAC `ClusterRole` which can be assigned to users within a team namespace:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be nice to call out that this is to be applied to the Gimbal cluster. At first it threw me off, and I started to think: "But how are they going to create services?" until I realized that these rules are for the Gimbal cluster.

Signed-off-by: Steve Sloka <steves@heptio.com>
@stevesloka
Copy link
Member Author

@alexbrand I added some more detail around the gimbal cluster.

@alexbrand
Copy link
Contributor

Sweet! LGTM

@alexbrand alexbrand merged commit 2230f53 into projectcontour:master May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants