Ensure a plugin isn't reported as passed if no results were read #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where the e2e plugin reported results (a tarball) but it did not contain an xml file of junit results we want to be sure to NOT count this as a success. It may be reasonble to consider this a failure but I think it is more generic/safe to just report it as unknown and users can handle that case differently. Also, I found another bug which was causing daemonsets to not properly be bubbling up their results. Fixes #840 Signed-off-by: John Schnake <jschnake@vmware.com>
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
==========================================
+ Coverage 46.19% 46.28% +0.08%
==========================================
Files 75 75
Lines 4788 4790 +2
==========================================
+ Hits 2212 2217 +5
+ Misses 2446 2445 -1
+ Partials 130 128 -2
Continue to review full report at Codecov.
|
zubron
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In the case where the e2e plugin reported results (a tarball) but
it did not contain an xml file of junit results we want to be sure
to NOT count this as a success.
It may be reasonable to consider this a failure but I think it is
more generic/safe to just report it as unknown and users can
handle that case differently.
Also, I found another bug which was causing daemonsets to not
properly be bubbling up their results.
Which issue(s) this PR fixes
Fixes #840
Special notes for your reviewer:
Release note: