Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update defaultRestorePriorities for CSI resources #1565

Closed
nrb opened this issue Jun 11, 2019 · 2 comments · Fixed by #2318
Closed

Update defaultRestorePriorities for CSI resources #1565

nrb opened this issue Jun 11, 2019 · 2 comments · Fixed by #2318
Assignees
Labels
Area/CSI Related to Container Storage Interface support Enhancement/User End-User Enhancement to Velero
Milestone

Comments

@nrb
Copy link
Contributor

nrb commented Jun 11, 2019

When restoring a CSI volume, the following resources should be restored before PVCs, in order to properly hook up references:

  • volumesnapshotcontents.snapshot.storage.k8s.io
  • volumesnapshot.snapshot.storage.k8s.io
  • volumesnapshoclass.snapshot.storage.k8s.io

A more complete list looks like this:

var defaultRestorePriorities = []string{
    "namespaces",
    "storageclasses",
    "customresourcedefinitions",
    "volumesnapshotclass.snapshot.storage.k8s.io",
    "volumesnapshotcontents.snapshot.storage.k8s.io",
    "volumesnapshots.snapshot.storage.k8s.io",
    "persistentvolumes",
    "persistentvolumeclaims",
    "secrets",
    "configmaps",
    "serviceaccounts",
    "limitranges",
    "pods",
    "replicaset",
}
@nrb nrb added the Area/CSI Related to Container Storage Interface support label Jun 11, 2019
@nrb nrb added this to the v1.1 milestone Jun 11, 2019
@nrb nrb self-assigned this Jun 11, 2019
@skriss
Copy link
Member

skriss commented Jun 11, 2019

For the prototype phase, we should consider just having users use the --restore-resource-priorities flag on the velero server command to configure this.

@nrb
Copy link
Contributor Author

nrb commented Jun 12, 2019

Yeah, that’s totally reasonable.

I’ll update docs and move this out of the v1.1 milestone.

@nrb nrb removed this from the v1.1 milestone Jul 17, 2019
@skriss skriss added this to the v1.2 milestone Aug 19, 2019
@skriss skriss added the Enhancement/User End-User Enhancement to Velero label Aug 29, 2019
@skriss skriss removed this from the v1.2 milestone Sep 10, 2019
@skriss skriss added this to the v1.3 milestone Nov 14, 2019
@nrb nrb changed the title Restore CSI CRs prior to PVCs Update defaultRestorePriorities for CSI resources Dec 16, 2019
@skriss skriss modified the milestones: v1.3, v1.4 Feb 4, 2020
@skriss skriss assigned ashish-amarnath and unassigned nrb Mar 6, 2020
@nrb nrb closed this as completed in #2318 Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area/CSI Related to Container Storage Interface support Enhancement/User End-User Enhancement to Velero
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants