Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for backup existence before download #1447

Merged
merged 3 commits into from May 6, 2019

Conversation

fabito
Copy link
Contributor

@fabito fabito commented May 4, 2019

Fixes #1410

Signed-off-by: fabito fuechi@ciandt.com

fabito added 2 commits May 4, 2019 15:05
Signed-off-by: fabito <fuechi@ciandt.com>
Signed-off-by: fabito <fuechi@ciandt.com>
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabito! Two small comments, otherwise LGTM.

pkg/cmd/cli/backup/download.go Outdated Show resolved Hide resolved
pkg/cmd/cli/backup/download.go Outdated Show resolved Hide resolved
Signed-off-by: fabito <fuechi@ciandt.com>
@fabito fabito marked this pull request as ready for review May 6, 2019 15:31
Copy link
Member

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @carlisia or @nrb PTAL, and please squash into a single commit when merging.

@nrb nrb merged commit 24d28c8 into vmware-tanzu:master May 6, 2019
jessestuart added a commit to jessestuart/velero that referenced this pull request May 25, 2019
* upstream/master: (169 commits)
  Always pull the docker layers on image build
  add changelog for v1.0.0-rc.1
  Fix instances of 'an Velero' typo
  Add documentation for minio running in KinD
  Add flag to disable creation of VSL on install
  Document more restic limitations
  update build-from-scratch.md for clarity, velero install cmd (vmware-tanzu#1458)
  Add new gauge to hold the timestamp of the last successful backup (vmware-tanzu#1448)
  shortcut expander: use discovery helper's cached resource list
  add links to the configurable BSL/VSL params on install pages
  Add note about restic support being beta (vmware-tanzu#1446)
  Check for backup existence before download (vmware-tanzu#1447)
  Add note about backups stuck InProgress
  add v0.11.1-beta.1 changelog
  add v1.0.0-beta.1 changelog
  Use latest container image when version is empty (vmware-tanzu#1439)
  add note about single credentials per provider to locations doc
  more docs updates (vmware-tanzu#1432)
  remove ref to v0.10 from BSL validation error msg (vmware-tanzu#1429)
  update docs/backup.md (vmware-tanzu#1427)
  ...
jessestuart pushed a commit to jessestuart/velero that referenced this pull request May 28, 2019
* check for backup existence in download command

Signed-off-by: fabito <fuechi@ciandt.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download backup command: check if backup exists first
3 participants