Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable shelf in production or protect with password #19

Open
jhomarolo opened this issue Oct 1, 2021 · 2 comments
Open

Disable shelf in production or protect with password #19

jhomarolo opened this issue Oct 1, 2021 · 2 comments
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed severity-nice-to-have Item is nice to have

Comments

@jhomarolo
Copy link
Contributor

Does it make sense to lock the shelf route in some native way?

Optionally display it only when the environment is not production or put some password to display it?

@jhomarolo jhomarolo added the enhancement New feature or request label Oct 1, 2021
@jhomarolo jhomarolo added help wanted Extra attention is needed severity-nice-to-have Item is nice to have labels Dec 24, 2021
@italojs
Copy link
Member

italojs commented Feb 9, 2022

It is a infraestructure responsability, I'm not sure if we need to bring it for herbs2shelf
buuut it is a super short feature, so we colud to add an env like "LOCKIN_ENV"
when I set the LOCKIN_ENV=production, we could to generate the HTML onlyif(process.env.NODE_ENV!==process.env.LOCKIN_ENV) else it we could to return an herbs error page HTML

@italojs
Copy link
Member

italojs commented May 4, 2022

Another option is to create some auth system like swagger https://swagger.io/docs/specification/authentication/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest help wanted Extra attention is needed severity-nice-to-have Item is nice to have
Projects
None yet
Development

No branches or pull requests

2 participants