Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment feature copied from augeasproviders_shellvar #57

Closed
wants to merge 98 commits into from
Closed

Add comment feature copied from augeasproviders_shellvar #57

wants to merge 98 commits into from

Conversation

jgrammen-agilitypr
Copy link
Contributor

first attempt at copying in the comment feature from shellvar.
this was a basic copy and paste

@puppet-community-rangefinder
Copy link

ssh_config is a type

Breaking changes to this file MAY impact these 6 modules (near match):

sshd_config is a type

Breaking changes to this file MAY impact these 18 modules (near match):

sshd_config_match is a type

Breaking changes to this file MAY impact these 1 modules (near match):

sshd_config_subsystem is a type

Breaking changes to this file MAY impact these 8 modules (near match):

This module is declared in 6 of 575 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@coveralls
Copy link

coveralls commented May 27, 2020 •
edited

Coverage Status

Coverage decreased (-0.4%) to 97.541% when pulling 4f26c5e on jgrammen-agilitypr:feature/add-comment into 1052668 on hercules-team:master.

raphink
raphink requested changes May 28, 2020
View reviewed changes
Copy link
Member

@raphink raphink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing commas

spec/unit/puppet/provider/ssh_config/augeas_spec.rb Outdated Show resolved Hide resolved
spec/unit/puppet/provider/ssh_config/augeas_spec.rb Outdated Show resolved Hide resolved
spec/unit/puppet/provider/sshd_config/augeas_spec.rb Outdated Show resolved Hide resolved
spec/unit/puppet/provider/sshd_config/augeas_spec.rb Outdated Show resolved Hide resolved
spec/unit/puppet/provider/sshd_config/augeas_spec.rb Outdated Show resolved Hide resolved
spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb Show resolved Hide resolved
spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb Outdated Show resolved Hide resolved
spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb Outdated Show resolved Hide resolved
spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb Outdated Show resolved Hide resolved
spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb Outdated Show resolved Hide resolved
jgrammen-agilitypr and others added 25 commits May 28, 2020 09:29
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/ssh_config/augeas_spec.rb
dc897e9 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/ssh_config/augeas_spec.rb
9a5d921 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config/augeas_spec.rb
55772bd 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config/augeas_spec.rb
63a8e5f 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config/augeas_spec.rb
fd11d05 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
bd7c30d 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
7ef56b2 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
79709a1 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
6e022e5 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
3870b4b 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
07b9d51 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/ssh_config/augeas_spec.rb
cd882fe 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr
Merge pull request #1 from hercules-team/master
d5d4054 
sshd_config_match: remove duplicated condition param in test (voxpupuli#58)
@jgrammen-agilitypr
Add comment feature copied from augeasproviders_shellvar
1d10796
@jgrammen-agilitypr
First attempt at unit tests
9510022
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/ssh_config/augeas_spec.rb
71d7bc9 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/ssh_config/augeas_spec.rb
76d6857 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config/augeas_spec.rb
95cedbc 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config/augeas_spec.rb
4f15023 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config/augeas_spec.rb
9d3d272 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
8d2caac 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
013f872 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
c89543d 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
5544684 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
221b2b6 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
jgrammen-agilitypr and others added 27 commits July 15, 2020 10:41
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
17b2893 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
834dfa3 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
7855997 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
32673ce 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
375bb4e 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/ssh_config/augeas_spec.rb
4a19f19 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
update bad tests
0cd30cf
@jgrammen-agilitypr @raphink
First attempt at unit tests
234eb5f
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_match/augeas_spec.rb
834d22d 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
Update spec/unit/puppet/provider/sshd_config_subsystem/augeas_spec.rb
5be6208 
Co-authored-by: Raphaël Pinson <github+aem1eeshi1@raphink.net>
@jgrammen-agilitypr @raphink
more cleanup and fixes
0f3fada
@raphink
use name instead of variable
cd5c821
@raphink
Remove unset logic
32eecba
@raphink
Fix merge tag
5f7f542
@raphink
fix most of ssh_config commenting logic
e5b83a0
@raphink
ssh_config: test comment change
3a77f58
@raphink
WIP: fix sshd_config
87cacbe
@raphink
Fix sshd_config tests
082faf3
@raphink
Fix ssh_config tests again
b343cb6
@raphink
Fix sshd_config tests again
676c0fc
@raphink
Remove trace
45067e0
@raphink
Adapt tests for sshd_config_match
6d54564
@raphink
WIP: fix comment iimplementation in sshd_config_match
d627547
@raphink
Fix sshd_config_match comments
1e762c2
@raphink
sshd_config_subsystem: fix specs
5bc9029
@jgrammen-agilitypr
Merge branch 'feature/add-comment' into pr-57_fixed
eaa4df9
@jgrammen-agilitypr
Merge pull request #3 from raphink/pr-57_fixed
4f26c5e 
Rebase on master and fix a few things
@raphink raphink mentioned this pull request Jul 15, 2020
Merged
@raphink
Copy link
Member

raphink commented Jul 15, 2020

Superceded by #61

@raphink raphink closed this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphink raphink raphink requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgrammen-agilitypr @coveralls @raphink