Treat values as simple/array based on local lens #65
Conversation
|
It looks like there are total testing failures here that might be tied not to any specific change I made, but a change in rspec itself. The last successful testing log shows that rspec in the 3.9.x series was used, but this test suite used the 3.10.x series. Please let me know how you want me to proceed here. I have verified this code in actual production use in my puppet environment, so I can at least attest it is not completely broken, even if I cannot pass the test suite here. |
|
I am a bit disappointed to see #68 merged, which only addresses the proximal issue of HostKeyAlgorithms, instead of this change, which would fix both that and any future issues of this type, while allowing a greater range of augeas providers. Could this PR please be reconsidered? |
|
Dear @tedgarb, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
|
Dear @tedgarb, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Sorry for the long silence here... Rebased this and as I hoped the CI tests succeeded now, I still think this is a somewhat more elegant solution to #64 that provides better forward/back compatibility, and politely request this be considered as a more general solution. |
|
Hi, wanted to check on whether there is anything I could do to get this merged? |
There was a problem hiding this comment.
I guess it works but I can't find where parsed_as? is defined. I see it in the changelog here but can't find the code: https://github.com/voxpupuli/puppet-augeasproviders/blob/0c1f9f6a60b29c14633d8820d827aacf568ed5dd/CHANGELOG.md?plain=1#L56
|
Hi, it's currently defined in https://github.com/voxpupuli/puppet-augeasproviders_core/blob/master/lib/puppet/provider/augeasprovider/default.rb#L583 |
|
Wanted to check in on this |
|
Checking in on this |
|
Wanted to query this again and ask if there is anything I can do to move it along. There is an errant "tests fail" label on this from a previous issue with the tests, but the tests have been passing for a while. |
|
Hey @tedgarb, |
This code previously used an explicitly defined list of labels that were treated as arrays and not simple values. This broke the sshd_config provider for users with a version of the sshd lens from augeas 1.9.0 or newer. To avoid breaking support for older users, and to be forward-compatible with new versions of augeas that are aware of additional array values, this change determines if a label is an array or simple value by testing what the underlying augeas provider returns
|
Got a little twisted trying to rebase before first coffee, but it's there now, should be good |
|
Thx for your contribution and patiance! :) |
This code previously used an explicitly defined list of labels that were
treated as arrays and not simple values. This broke the sshd_config
provider for users with a version of the sshd lens from augeas 1.9.0 or
newer. To avoid breaking support for older users, and to be
forward-compatible with new versions of augeas that are aware of
additional array values, this change determines if a label is an array
or simple value by testing what the underlying augeas provider returns
Addresses #64