Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force data read from 'sysctl -a' into ASCSII #46

Merged
merged 1 commit into from Oct 22, 2020

Conversation

lukebigum
Copy link
Contributor

Avoids Puppet complaining about invalid Unicode. Bit of a hack, but gets around https://bugzilla.redhat.com/show_bug.cgi?id=1879868

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 88.136% when pulling edb79e9 on lukebigum:unicode_fix into e58fc8e on hercules-team:master.

@raphink
Copy link
Member

raphink commented Oct 10, 2020

Thanks. It's better than nothing indeed. Are you able to provide tests for this?

@foxxx0
Copy link
Member

foxxx0 commented Oct 19, 2020

Tested manually on a system that suffers frome the same issue and I can confirm that it works here.

I suppose the test should inject some sort of invalid utf8 sequences and expect not to contain them in the output lines? Or maybe put the code into its own method for easier testing and just mapping it to the sysctl -a lines array before iterating it?

@raphink
Copy link
Member

raphink commented Oct 22, 2020

Oh well, I'll just merge like this 🤷

@raphink raphink merged commit 6db14b1 into voxpupuli:master Oct 22, 2020
@bastelfreak
Copy link
Member

@raphink thanks for merging. could you push a new release?

@raphink
Copy link
Member

raphink commented Oct 28, 2020

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants