You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Damage caused by the Venom Status caused by Venom Dust will not contribute to Exp gained when the monster is killed
To Reproduce
Note down monster's HP fraction
Poison monster using Venom Dust
Let Poison cause damage
Note down monster's HP fraction after Poison has stopped dealing damage
Kill monster and observe the exp value gained: It's X percent of the monster's base exp, with X being "100 - HP fraction of damage dealt by poison". In other words: You gain exp as if another player had caused the damage to the monster.
Expected behavior
Poison caused by the player's venom dust contributes to the players' damage count on the monster
Additional context
According to my investigation (but untested), the bug is caused in skill.c:1663, where UNT_VenomDust applies its poison-status effect. In other usages of the status->change_start()-function, the 6th parameter is used to pass in the source-entity (player/monster) that caused the poison, and this value will be used to attribute damage contribution by the status. For VenomDust, the unit-group's group-Id (sg->group_id, an internal value unrelated to the player) is passed into this parameter, instead of the unit-group's source id (sg->src_id, which would be the monster/player that placed the skill).
The text was updated successfully, but these errors were encountered:
Describe the bug
Damage caused by the Venom Status caused by Venom Dust will not contribute to Exp gained when the monster is killed
To Reproduce
Expected behavior
Poison caused by the player's venom dust contributes to the players' damage count on the monster
Additional context
According to my investigation (but untested), the bug is caused in skill.c:1663, where UNT_VenomDust applies its poison-status effect. In other usages of the status->change_start()-function, the 6th parameter is used to pass in the source-entity (player/monster) that caused the poison, and this value will be used to attribute damage contribution by the status. For VenomDust, the unit-group's group-Id (sg->group_id, an internal value unrelated to the player) is passed into this parameter, instead of the unit-group's source id (sg->src_id, which would be the monster/player that placed the skill).
The text was updated successfully, but these errors were encountered: