Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poison Status damage caused by Venom Dust doesn't count for exp #3188

Closed
Owlrrex opened this issue Jan 15, 2023 · 1 comment
Closed

Poison Status damage caused by Venom Dust doesn't count for exp #3188

Owlrrex opened this issue Jan 15, 2023 · 1 comment

Comments

@Owlrrex
Copy link

Owlrrex commented Jan 15, 2023

Describe the bug
Damage caused by the Venom Status caused by Venom Dust will not contribute to Exp gained when the monster is killed

To Reproduce

  1. Note down monster's HP fraction
  2. Poison monster using Venom Dust
  3. Let Poison cause damage
  4. Note down monster's HP fraction after Poison has stopped dealing damage
  5. Kill monster and observe the exp value gained: It's X percent of the monster's base exp, with X being "100 - HP fraction of damage dealt by poison". In other words: You gain exp as if another player had caused the damage to the monster.

Expected behavior
Poison caused by the player's venom dust contributes to the players' damage count on the monster

Additional context
According to my investigation (but untested), the bug is caused in skill.c:1663, where UNT_VenomDust applies its poison-status effect. In other usages of the status->change_start()-function, the 6th parameter is used to pass in the source-entity (player/monster) that caused the poison, and this value will be used to attribute damage contribution by the status. For VenomDust, the unit-group's group-Id (sg->group_id, an internal value unrelated to the player) is passed into this parameter, instead of the unit-group's source id (sg->src_id, which would be the monster/player that placed the skill).

@aoshfan
Copy link

aoshfan commented Feb 21, 2023

Hi @Owlrrex , i am not sure if this suppose to be an issue or not because in the official server Venom Dust doesn't contribute to exp as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants