Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flee reduction doesn't match official/iRO Classic Wiki #3273

Closed
Asonael opened this issue Jan 19, 2024 · 1 comment
Closed

Flee reduction doesn't match official/iRO Classic Wiki #3273

Asonael opened this issue Jan 19, 2024 · 1 comment
Labels
invalid Issue isn't a Hercules bug (user mistake, intentional behavior, unsupported setup, etc) mode:pre-renewal For strictly Pre-Renewal issues

Comments

@Asonael
Copy link

Asonael commented Jan 19, 2024

Describe the bug
Flee reduction from multiple monsters is not calculated correctly to match official (via iRO wiki classic)

https://irowiki.org/classic/FLEE

Skill bonuses should be outside of the reduction of flee.
Expected behavior (from above): Actual Flee = Skill Bonus + [Level+ AGI + Item Bonus] * [1 - ((Mobs -2) * 0.1)]
Behavior on Hercules: Actual Flee = [Skill Bonus + Level+ AGI + Item Bonus] * [1 - ((Mobs -2) * 0.1)]

To Reproduce
Steps to reproduce the behavior:
Tested on 13 Kukre with 102 required FLEE for 95% dodge, reducing flee to 1. Every attack hits except lucky dodges. Should have 41 flee and dodge over 1/3rd of the attacks if Improve Dodge was calculated outside of flee reduction.

image

@skyleo
Copy link
Contributor

skyleo commented Jan 24, 2024

@skyleo is this something you can check in your sources?

In 11.2 pre-re Aegis (this->characterInfo).basicAvoidance is used for calclulating CPC::GetAvoidableSuccessPercent

and CPC::UpdateAvoidableSucPerOnClient is used for updating this value, which does take TF_MISS there into account, when setting (this->characterInfo).basicAvoidance.

So iRO Classic Wiki is wrong, unless it changed later in Aegis, usually unlikely for such basic mechanics though.

What should be noted though is that incorrectly Hercules doesn't cap the amount of enemies that affect Flee. In Aegis only 12 enemies at most can affect Flee and 2 of them are still removed from the calculation. Meaning any amount of enemies above 12 is handled the same as exactly 12 enemies in relation to the flee penalty.

@skyleo skyleo closed this as completed Jan 24, 2024
@skyleo skyleo added invalid Issue isn't a Hercules bug (user mistake, intentional behavior, unsupported setup, etc) mode:pre-renewal For strictly Pre-Renewal issues labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Issue isn't a Hercules bug (user mistake, intentional behavior, unsupported setup, etc) mode:pre-renewal For strictly Pre-Renewal issues
Projects
None yet
Development

No branches or pull requests

2 participants