Pip: Write a meaningful error to the report if installing dependencie…

…s fails Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
oss-review-toolkit · May 3, 2019 · 496da07 · 496da07
1 parent e2c5bfc
commit 496da07
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/analyzer/src/main/kotlin/managers/Pip.kt b/analyzer/src/main/kotlin/managers/Pip.kt
@@ -501,7 +501,11 @@ class Pip(
         }
 
         virtualEnvDir = createVirtualEnv(workingDir, projectPythonVersion)
-        installDependencies(workingDir, definitionFile, virtualEnvDir).requireSuccess()
+        val install = installDependencies(workingDir, definitionFile, virtualEnvDir)
+        if (install.isError) {
+            // pip writes the real error message to stdout instead of stderr.
+            throw IOException(install.stdout)
+        }
 
         log.info {
             "Successfully installed dependencies for project '$definitionFile' using Python $projectPythonVersion."