Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripting convenience #1013

Merged
merged 4 commits into from Nov 9, 2018
Merged

Scripting convenience #1013

merged 4 commits into from Nov 9, 2018

Conversation

sschuberth
Copy link
Member

@sschuberth sschuberth commented Nov 8, 2018

Please have a look at the individual commit messages for the details.


This change is Reviewable

Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
@codecov
Copy link

codecov bot commented Nov 8, 2018

Codecov Report

Merging #1013 into master will decrease coverage by 6.1%.
The diff coverage is 7.4%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1013      +/-   ##
============================================
- Coverage     55.43%   49.32%   -6.11%     
  Complexity      256      256              
============================================
  Files           110      110              
  Lines          5392     5413      +21     
  Branches        818      822       +4     
============================================
- Hits           2989     2670     -319     
- Misses         1932     2308     +376     
+ Partials        471      435      -36
Impacted Files Coverage Δ Complexity Δ
cli/src/main/kotlin/commands/EvaluatorCommand.kt 11.11% <ø> (ø) 1 <0> (ø) ⬇️
model/src/main/kotlin/OrtResult.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
model/src/main/kotlin/Identifier.kt 47.61% <0%> (-6.44%) 12 <0> (ø)
model/src/main/kotlin/ScanResultContainer.kt 44.44% <0%> (-35.56%) 4 <0> (ø)
...eporter/src/main/kotlin/reporters/TableReporter.kt 57.43% <100%> (+1.51%) 0 <0> (ø) ⬇️
scanner/src/main/kotlin/scanners/BoyterLc.kt 0% <0%> (-72.14%) 0% <0%> (ø)
scanner/src/main/kotlin/scanners/Askalono.kt 0% <0%> (-71.43%) 0% <0%> (ø)
scanner/src/main/kotlin/scanners/Licensee.kt 0% <0%> (-60%) 0% <0%> (ø)
downloader/src/main/kotlin/vcs/GitRepo.kt 17.64% <0%> (-52.95%) 0% <0%> (ø)
downloader/src/main/kotlin/vcs/Cvs.kt 13.41% <0%> (-39.03%) 0% <0%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fac43cc...9508b3b. Read the comment docs.

model/src/main/kotlin/OrtResult.kt Outdated Show resolved Hide resolved
model/src/main/kotlin/ScanResultContainer.kt Outdated Show resolved Hide resolved
model/src/main/kotlin/ScanResultContainer.kt Outdated Show resolved Hide resolved
model/src/main/kotlin/OrtResult.kt Outdated Show resolved Hide resolved
model/src/main/kotlin/OrtResult.kt Show resolved Hide resolved
model/src/main/kotlin/Identifier.kt Outdated Show resolved Hide resolved
model/src/main/kotlin/OrtResult.kt Outdated Show resolved Hide resolved
This is mainly for upcoming scripting convenience, but it can also be
used to slightly simplify the TableReporter code.

Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
This is mainly for upcoming scripting convenience, but it can also be
used to slightly simplify the TableReporter code.

Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
Signed-off-by: Sebastian Schuberth <sebastian.schuberth@here.com>
@sschuberth
Copy link
Member Author

Merging despite the unrelated AppVeyor failure.

@sschuberth sschuberth merged commit e041032 into master Nov 9, 2018
@sschuberth sschuberth deleted the scripting-convenience branch November 9, 2018 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants