Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluator module #1036

Merged
merged 2 commits into from Nov 19, 2018
Merged

Evaluator module #1036

merged 2 commits into from Nov 19, 2018

Conversation

mnonnenmacher
Copy link
Member

@mnonnenmacher mnonnenmacher commented Nov 19, 2018

Move the evaluator logic to its own module.


This change is Reviewable

evaluator/src/test/kotlin/EvaluatorTest.kt Outdated Show resolved Hide resolved
evaluator/src/test/kotlin/EvaluatorTest.kt Outdated Show resolved Hide resolved
This makes it easier to test the code.

Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@here.com>
Signed-off-by: Martin Nonnenmacher <martin.nonnenmacher@here.com>
@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #1036 into master will decrease coverage by 4.8%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1036      +/-   ##
============================================
- Coverage     55.17%   50.37%   -4.81%     
  Complexity      256      256              
============================================
  Files           110      110              
  Lines          5455     5441      -14     
  Branches        834      831       -3     
============================================
- Hits           3010     2741     -269     
- Misses         1979     2263     +284     
+ Partials        466      437      -29
Impacted Files Coverage Δ Complexity Δ
cli/src/main/kotlin/commands/EvaluatorCommand.kt 8.69% <0%> (+0.58%) 1 <0> (ø) ⬇️
scanner/src/main/kotlin/scanners/BoyterLc.kt 0% <0%> (-72.14%) 0% <0%> (ø)
scanner/src/main/kotlin/scanners/Askalono.kt 0% <0%> (-71.43%) 0% <0%> (ø)
scanner/src/main/kotlin/scanners/Licensee.kt 0% <0%> (-60%) 0% <0%> (ø)
downloader/src/main/kotlin/vcs/GitRepo.kt 17.64% <0%> (-52.95%) 0% <0%> (ø)
downloader/src/main/kotlin/vcs/Cvs.kt 13.41% <0%> (-39.03%) 0% <0%> (ø)
downloader/src/main/kotlin/DownloadException.kt 33.33% <0%> (-33.34%) 0% <0%> (ø)
downloader/src/main/kotlin/vcs/Mercurial.kt 31.03% <0%> (-31.04%) 0% <0%> (ø)
downloader/src/main/kotlin/WorkingTree.kt 54.54% <0%> (-27.28%) 0% <0%> (ø)
downloader/src/main/kotlin/Downloader.kt 32.06% <0%> (-22.14%) 0% <0%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd0df8a...0802f16. Read the comment docs.

@mnonnenmacher mnonnenmacher merged commit d010aa8 into master Nov 19, 2018
@mnonnenmacher mnonnenmacher deleted the evaluator-module branch November 19, 2018 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants